Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment about zero length case in batch verification #3367

Merged
merged 1 commit into from
May 17, 2023

Conversation

jtraglia
Copy link
Member

The team auditing c-kzg-4844 had this minor critique, which I agree with:

I think it may be worth the extra clarifications in the specs on how the zero length case should be handled.

This PR adds a comment to the verify_blob_kzg_proof_batch docstring about this.

Also, delete the blank line to be more in line with other docstrings. For example:

"""
Compute KZG proof at point `z` for the polynomial represented by `blob`.
Do this by computing the quotient polynomial in evaluation form: q(x) = (p(x) - p(z)) / (x - z).
Public method.
"""

"""
Verify KZG proof that ``p(z) == y`` where ``p(z)`` is the polynomial represented by ``polynomial_kzg``.
Receives inputs as bytes.
Public method.
"""

Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@asn-d6 asn-d6 merged commit 32358e8 into ethereum:dev May 17, 2023
@jtraglia jtraglia deleted the comment-about-zero-elements branch May 17, 2023 17:01
mkalinin pushed a commit to mkalinin/eth2.0-specs that referenced this pull request May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants