Add comment about zero length case in batch verification #3367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The team auditing c-kzg-4844 had this minor critique, which I agree with:
This PR adds a comment to the
verify_blob_kzg_proof_batch
docstring about this.Also, delete the blank line to be more in line with other docstrings. For example:
consensus-specs/specs/deneb/polynomial-commitments.md
Lines 445 to 449 in fe9c1a8
consensus-specs/specs/deneb/polynomial-commitments.md
Lines 358 to 362 in fe9c1a8