-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs about how to add a new feature proposal in consensus-specs and online viewer support #3239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! minor nit
I'm trying to use mkdocs to build the docs website. Preview website: https://hwwhww.github.io/consensus-specs/
@djrtwo @ralexstokes what do you think about the CI-built spec viewer website proposal? |
spec viewer website looks cool! I don't immediately see what it buys us over the default GitHub UI but it likely doesn't hurt anything to add it |
Hmm. I wonder if it could be done in a way that allows selecting consensusfork in a corner, and also shows any inherited functions. https://hwwhww.github.io/consensus-specs/specs/capella/light-client/sync-protocol/ it looks clean though :) |
I think it's doable, but I may need to write a custom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Türkiye
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Türkiye
docs
folderdocs/docs/new-feature.md
doc as the new feature guidemkdocs
mkdocs.yml
specs/*
path, I created acopy_docs
makefile command to copy the specs files todocs/
folder. The GitHub Actions job would callmake copy_docs
and build the docs viewer website.fork_choice/.pages
andspecs/.pages
files formkdocs-awesome-pages-plugin
navigation.tests/
folder are still wrong. The simplest solution is using absolute links here. Anothor solution is to arrange thetests
docs all together.