Explicitly validate public key when processing Deposit #2987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deposits are the only source of non-validated public keys, so suggesting to add explicit public key validation statement to
process_deposit
function.bls.Verify
function (and its batch variants) is a bit ambiguous in the case ifBLSPubkey
is not valid (either invalid serialization or outside of the curve or outside of the group): whether it should returnfalse
or throw an error.In all other cases (besides
process_deposit
)bls.Verify
can't receive an invalidBLSPubkey
since all of them come from the state and are inherently valid. Reasoning that way it could make sense to throw error if invalid pubkey is passed tobls.Verify
since it would mean kind of fatal implementation error. In that case suggested implicit public key validation makes sense.