Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profiling instructions for Linux #506

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

agnxsh
Copy link
Contributor

@agnxsh agnxsh commented Sep 7, 2024

The debian package name gperftools is now deprecated, and is replaced with libgoogle-perftools-dev. Additionally the pprof binary seems to be decoupled from perftools, for debian we would separately install it from Go packages.

image

Overall the instructions would look like this now:
image

@jtraglia
Copy link
Member

jtraglia commented Sep 7, 2024

Thanks! I'm going to wait to merge this until you've successfully run the profiler. There might be other issues; it's been a while since I've tested this on Linux.

@jtraglia jtraglia changed the title gperftools package name no longer used for .deb Fix profiling instructions for Linux Sep 7, 2024
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@jtraglia jtraglia merged commit 1f5d7b8 into ethereum:main Sep 7, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants