Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "/v2" to Go module name #504

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Add "/v2" to Go module name #504

merged 1 commit into from
Aug 30, 2024

Conversation

jtraglia
Copy link
Member

Seems that this is necessary for a v2 release...

https://pkg.go.dev/github.com/ethereum/c-kzg-4844?tab=versions

Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite unfortunate :(

@jtraglia jtraglia merged commit 2365786 into ethereum:main Aug 30, 2024
41 checks passed
@jtraglia jtraglia deleted the go-v2 branch August 30, 2024 18:24
@tarassh
Copy link

tarassh commented Aug 31, 2024

HI @jtraglia, I think this PR has no effect to versioning. If the version 2 is incompatible it has to go to v2 subdirectory.
https://go.dev/blog/v2-go-modules

as an example https://github.com/googleapis/gax-go

@jtraglia
Copy link
Member Author

jtraglia commented Aug 31, 2024

Hey @tarassh thanks for the comment. I'm definitely not an expert on this but I think it's enough to append v2 to the module name. We will still need to make a new v2.0.1 release for this to show up on pkg.go.dev though. Are you sure the v2 code must go into a new v2 directory?

Edit: from the following link, I want to do option 1 and you're suggesting option 2. Both are valid IIUC. Right?

https://go.dev/wiki/Modules#releasing-modules-v2-or-higher

@tarassh
Copy link

tarassh commented Aug 31, 2024

Yes, just follow the links to get more context.
Eventually you should be able to see this https://pkg.go.dev/github.com/googleapis/gax-go?tab=versions with this repo.

UPD: the answer refers to the question before the edit.

@jtraglia
Copy link
Member Author

Eventually you should be able to see this https://pkg.go.dev/github.com/googleapis/gax-go?tab=versions with this repo.

I see. But that project chose that way of handling things. It's not strictly necessary. Unless it's required, I'd rather not maintain two versions of the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants