Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document compute_commitment_to_aggregated_interpolation_poly() #500

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

asn-d6
Copy link
Contributor

@asn-d6 asn-d6 commented Aug 23, 2024

I feel like compute_commitment_to_aggregated_interpolation_poly() is a bit complicated. I'm not sure if it can be simplified in terms of code, but IMO the documentation can be improved, so that the reader can more easily understand what's happening.

This opinionated PR adds some documentation and renames some variables. This PR should not change the logic at all.

Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some small nits.

src/eip7594/eip7594.c Outdated Show resolved Hide resolved
src/eip7594/eip7594.c Outdated Show resolved Hide resolved
src/eip7594/eip7594.c Outdated Show resolved Hide resolved
@asn-d6
Copy link
Contributor Author

asn-d6 commented Aug 23, 2024

Thanks for review!

@asn-d6 asn-d6 merged commit 2b38295 into ethereum:main Aug 23, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants