Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify_cell_kzg_proof_batch(): Split it up further #499

Merged
merged 8 commits into from
Aug 23, 2024

Conversation

asn-d6
Copy link
Contributor

@asn-d6 asn-d6 commented Aug 23, 2024

This PR continues on the spirit of #494.

  • It abstracts two small helper functions out of the main function.
  • It removes one fr array that was not needed.

IMO the verification function is getting more manageable now.

Copy link
Contributor

@b-wagn b-wagn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, that's a good structure! Thanks.

src/eip7594/eip7594.c Outdated Show resolved Hide resolved
src/eip7594/eip7594.c Outdated Show resolved Hide resolved
src/eip7594/eip7594.c Outdated Show resolved Hide resolved
asn-d6 and others added 3 commits August 23, 2024 14:00
Co-authored-by: Benedikt Wagner <113296072+b-wagn@users.noreply.github.com>
Co-authored-by: Benedikt Wagner <113296072+b-wagn@users.noreply.github.com>
src/eip7594/eip7594.c Outdated Show resolved Hide resolved
src/eip7594/eip7594.c Outdated Show resolved Hide resolved
src/eip7594/eip7594.c Outdated Show resolved Hide resolved
src/eip7594/eip7594.c Show resolved Hide resolved
src/eip7594/eip7594.c Outdated Show resolved Hide resolved
src/eip7594/eip7594.c Outdated Show resolved Hide resolved
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making those changes.

@asn-d6
Copy link
Contributor Author

asn-d6 commented Aug 23, 2024

Thanks for the review!

@asn-d6 asn-d6 merged commit 7126419 into ethereum:main Aug 23, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants