Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat some function param docs for consistency #496

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

jtraglia
Copy link
Member

There were some functions using a single space vs a tab (of spaces) between the params.

@jtraglia
Copy link
Member Author

There were some minor changes. Please review the diff with "hide whitespace changes" to see them.

@asn-d6
Copy link
Contributor

asn-d6 commented Aug 16, 2024

I think the style convention of the function documentation params frequently adds a review roundtrip. Is it possible to automatically format them?

Personally, I don't feel strong at all about this, and I'm OK with merging this PR anyway.

@jtraglia
Copy link
Member Author

Is it possible to automatically format them?

I wish. To my knowledge, so such tool exists for C. One might be able to write their own clang-tidy checker. But I imagine that would involve quite a bit of work.

Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@asn-d6 asn-d6 merged commit 4b915a6 into ethereum:main Aug 19, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants