Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In batch cell verification, take commitment for each cell #451

Merged
merged 10 commits into from
Jul 11, 2024
Merged

In batch cell verification, take commitment for each cell #451

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
35b470f
Start to change API for batch cell verification
jtraglia Jul 3, 2024
ed783bd
Make dedup_comms static
jtraglia Jul 3, 2024
12caf79
Fix my mistakes
jtraglia Jul 3, 2024
d989f40
Add comment
jtraglia Jul 3, 2024
98db77e
Fix issue with deduplicate_commitments
jtraglia Jul 5, 2024
f18e18b
Add deduplicate_commitments tests
jtraglia Jul 5, 2024
c688a04
Merge remote-tracking branch 'origin/das' into das-dedup-comms
jtraglia Jul 9, 2024
387b165
Add "out" to param names
jtraglia Jul 9, 2024
b01055c
Update reference tests
jtraglia Jul 9, 2024
9290b54
Improve getColumns for Go benchmarks
jtraglia Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment
  • Loading branch information
@jtraglia
jtraglia committed Jul 3, 2024
commit d989f40577220cb793538c163a36858331852db0
11 changes: 7 additions & 4 deletions src/c_kzg_4844.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3803,11 +3803,9 @@ C_KZG_RET verify_cell_kzg_proof_batch(
size_t num_commitments;
void **tmp = NULL;

/* Dedup arrays */
/* Arrays */
Bytes48 *unique_commitments = NULL;
uint64_t *row_indices = NULL;

/* Arrays */
bool *is_cell_used = NULL;
fr_t *aggregated_column_cells = NULL;
fr_t *aggregated_interpolation_poly = NULL;
Expand Down Expand Up @@ -3847,7 +3845,12 @@ C_KZG_RET verify_cell_kzg_proof_batch(
ret = c_kzg_calloc(tmp, num_cells, sizeof(uint64_t));
if (ret != C_KZG_OK) goto out;


/*
* Convert the array of cell commitments to an array of unique commitments
* and an array of indices to those unique commitments. We do this before
* the array allocations section below because we need to know how many
* commitment weights there will be.
*/
num_commitments = num_cells;
memcpy(unique_commitments, commitments_bytes, num_cells * sizeof(Bytes48));
deduplicate_commitments(unique_commitments, row_indices, &num_commitments);
Expand Down