Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PendingBalanceDeposit to PendingDeposit #478

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Rename PendingBalanceDeposit to PendingDeposit #478

merged 4 commits into from
Oct 9, 2024

Conversation

ensi321
Copy link
Contributor

@ensi321 ensi321 commented Oct 9, 2024

The latest spec renames PendingBalanceDeposit to PendingDeposit. Same with the field pending_balance_deposits to pending_deposits in beacon state

nflaig
nflaig reviewed Oct 9, 2024
View reviewed changes
types/electra/deposit.yaml Outdated Show resolved Hide resolved
ralexstokes
ralexstokes approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

@nflaig nflaig merged commit 02d595d into ethereum:master Oct 9, 2024
3 checks passed
@ensi321 ensi321 deleted the alpha8 branch October 10, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes approved these changes

@nflaig nflaig nflaig approved these changes

@james-prysm james-prysm james-prysm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ensi321 @ralexstokes @nflaig @james-prysm