Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getAggregatedAttestationV2 to support EIP-7549 #447

Merged
merged 8 commits into from
Jun 27, 2024

Conversation

ensi321
Copy link
Contributor

@ensi321 ensi321 commented May 9, 2024

AttestationData post-electra is committee-indifferent, and thus, the same attestation_data_root might be shared across different committees.

An aggregator is only interested in attestations in its corresponding committee. getAggregatedAttestationV1 might aggregate attestations from multiple committees since committee_index is not in its params.

This PR adds getAggregatedAttestationV2 to aggregate attestations given attestation_data_root + slot + committee_index.

Part of #445

@rkapka
Copy link
Collaborator

rkapka commented May 16, 2024

Adding to @nflaig 's comments, if we make committee index required then this endpoint will not be backwards compatible and validator clients will have to be aware of both.

nflaig
nflaig previously approved these changes May 24, 2024
@nflaig nflaig changed the title Add getAggregatedAttestationV2 Add getAggregatedAttestationV2 to support EIP-7549 Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants