Move state endpoint to beacon namespace#353
Merged
Conversation
rolfyone
reviewed
Sep 18, 2023
Contributor
rolfyone
left a comment
rolfyone
left a comment
There was a problem hiding this comment.
LGTM, add this to the change list so we don't forget :)
GAEAlimited
approved these changes
Sep 18, 2023
Contributor
|
Uh, this was merged a bit quickly without time for feedback, but the condition we've discussed in the past for having the state endpoint in the official part of the api was to limit it to SSZ only - I think that change should be made, ie it's not feasible to create an expectation that client open up providing JSON for the state, which soon will reach GB sizes. |
Contributor
|
There was also discussion of fixing the flags encoding for json which is irregular with respect to its underlying intent. |
rolfyone
added a commit
to rolfyone/beacon-APIs
that referenced
this pull request
Sep 19, 2023
This reverts commit 4cc8484.
Contributor
|
sorry @rkapka can you re-open a pull request for this to allow discussion to happen? I've reverted it from master after out of band discussions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /eth/v2/debug/beacon/states/{state_id} endpoint is widely used by regular users and as such should probably not be present in the
debugnamespace. I think the original reason for putting it there was the large size of the response, but currently requesting all validators from/eth/v1/beacon/states/head/validatorsresults in an even larger response.This PR:
/eth/v1/beacon/states/{state_id}endpoint (the debug version isv2, but since we are moving it to a new namespace, in my opinion versioning should start anew)