Add sync_committee_rewards
#262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@michaelsproul how do you plan to fulfill this API? AFAIK we don't have that information available after block processing since the rewards are "merged" into the balances array |
ensi321
reviewed
Nov 11, 2022
ensi321
reviewed
Nov 11, 2022
ensi321
reviewed
Nov 11, 2022
ensi321
reviewed
Nov 11, 2022
Contributor
|
@dapplion I'm intending to replay blocks. For sync aggregates it's just a matter of loading the pre-state, and calculating the rewards based on the bits set in the sync aggregate |
Contributor
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
Looking good! Almost ready to go I think
kevinbogner
changed the title
sync_committee_rewardssync_committee_rewards
michaelsproul
previously approved these changes
Nov 16, 2022
Contributor
michaelsproul
left a comment
michaelsproul
left a comment
There was a problem hiding this comment.
LGTM, I'm happy to merge.
rolfyone
reviewed
Nov 16, 2022
Contributor
|
Just renamed types/sync_committee_rewards.yaml to rewards.yaml. It will be merged with types/rewards.yaml in the other PR |
rolfyone
previously approved these changes
Nov 18, 2022
Contributor
rolfyone
left a comment
rolfyone
left a comment
There was a problem hiding this comment.
LGTM, I think post will be better once you get into it, so thanks for persisting!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #260 (review)
/eth/v1/beacon/rewards/sync_committee/{block_id}{ "execution_optimistic": false, "finalized": false, "data": [ { "validator_index": "0", "reward": "2000" } ] }