Fix typos #261
Merged
Fix typos #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
commented
Nov 8, 2022
| @@ -89,7 +89,7 @@ get: | |||
| light_client_optimistic_update: | |||
| description: The node's latest known `LightClientOptimisticUpdate` has been updated | |||
| value: | | |||
| event: light_client_optimimstic_update | |||
| event: light_client_optimistic_update | |||
There was a problem hiding this comment.
Is renaming the event a potential problem? I checked the lodestar implementation and they use the proper value light_client_optimistic_update in the code without the typo.
There was a problem hiding this comment.
IMO renaming to remove a typo is OK, if a client actually implemented the typo'd version I think it would be sensible to deprecate/remove the typo version.
There was a problem hiding this comment.
Ok with removing the typo 👍
michaelsproul
approved these changes
Nov 8, 2022
ralexstokes
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixed some typos I found when looking through the specs.