Add not found responses for aggregates and contributions #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea how I broke that lint! |
mpetrunic
force-pushed
the
404-response
branch
from
31a6f9b
to
c17f699
Compare
mpetrunic
approved these changes
Feb 21, 2022
mpetrunic
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are times when an aggregate or contribution is requested by a VC, and the beacon node simply doesn't have any information to return.
Returning 400 'bad request' is probably excessive in this case, the request may be perfectly valid and it's just that the BN wasn't able to respond with data.
We believe that a 404 in these cases would be warranted and allow us a better idea of actual bad requests vs. no data being found at the BN.