-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Removed PARANOID build option (#5631) #5655
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5655 +/- ##
=========================================
+ Coverage 62.79% 62.8% +<.01%
=========================================
Files 349 348 -1
Lines 29722 29707 -15
Branches 3346 3345 -1
=========================================
- Hits 18665 18657 -8
+ Misses 9845 9838 -7
Partials 1212 1212 |
libdevcore/OverlayDB.cpp
Outdated
@@ -140,7 +140,7 @@ bool OverlayDB::exists(h256 const& _h) const | |||
|
|||
void OverlayDB::kill(h256 const& _h) | |||
{ | |||
#if ETH_PARANOIA || 1 | |||
#if 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The #if 1
is useless now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing, just removed the block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, you should not. Leave the #if 1
block and remove the #else
one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, oversight on my part - just changed it.
Are you able to squash 2 last commits? |
c1dba47
to
4417642
Compare
Should now be squashed 👍 |
Ok, great. I will merge it as soon the Windows build finishes. |
Fix #5631 - Remove PARANOID build and
#define ETH_PARANOIA