This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Use libscrypt from Hunter #4873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The decrypted private key does not match the expected one. I'm not able to track down the history of this test case.
|
axic
reviewed
Mar 6, 2018
| @@ -155,6 +158,3 @@ if (TESTS) | |||
| enable_testing() | |||
| add_subdirectory(test) | |||
| endif() | |||
|
|
|||
| # TODO: Split out json_spirit, libscrypt and sec256k1. | |||
| add_subdirectory(utils) | |||
There was a problem hiding this comment.
So its not even needed for json_spirit?
There was a problem hiding this comment.
We use json_spirit by loading headers only. This is an old CMake script that was not used.
|
This test is failing from time to time only on CircleCI / macOS. To be disabled, because we cannot find the reason. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed 2 tests, disabled 1.
The disabled test tests keyfile v2. I'm not sure what the expected result should be. I've found this commit adding the compatibility with v2: 8399161 but it does not include the test. I cannot find where the test was added.
Resolves #4815.