Skip to content

Add ERC: Splitting and Merging of NFTs #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 53 commits into
base: master
Choose a base branch
from

Conversation

nitin312
Copy link

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Feb 27, 2025

File EIPS/eip-7891.md

Requires 1 more reviewers from @g11tech, @lightclient, @SamWilsn, @xinbenlv

File ERCS/erc-7891.md

Requires 1 more reviewers from @g11tech, @SamWilsn, @xinbenlv

@eip-review-bot eip-review-bot changed the title erc 7891 update1 Add ERC: Splitting and Merging of NFTs Feb 27, 2025
@github-actions github-actions bot added the w-ci label Feb 27, 2025
Copy link

@bomanaps bomanaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, could you also review the red flags raised by the bots and properly format the links?

@bomanaps
Copy link

bomanaps commented Feb 27, 2025

You have two PRs open for the same proposal? PR 923 , PR 920

@github-actions github-actions bot added the w-ci label Apr 18, 2025
Copy link
Author

@nitin312 nitin312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated content based on reviewers feedback

Copy link
Author

@nitin312 nitin312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content for Rationale added

Copy link
Author

@nitin312 nitin312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated ERC-7891

@github-actions github-actions bot removed the w-ci label Apr 21, 2025
Copy link
Author

@nitin312 nitin312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added events in interface

Copy link
Author

@nitin312 nitin312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated ERC-7891.sol

@nitin312 nitin312 requested a review from SamWilsn April 23, 2025 05:58
Copy link

The commit 0843dc8 (as a parent of 311bb15) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Apr 24, 2025
Copy link
Author

@nitin312 nitin312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated ERC-7891 file

@github-actions github-actions bot removed the w-ci label Apr 24, 2025
@nitin312
Copy link
Author

@SamWilsn, @bomanaps, and @eip-review-bot, could you please take a moment to review this pull request? It includes the final draft of the ERC-7891 proposal and related code changes.

Your feedback would be greatly appreciated before we proceed with merging. Let me know if you have any questions or need further clarifications!

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants