Add ERC: Crosschain Broadcaster #897
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eip-review-bot
changed the title
yahgwai
changed the title
Skaillet91
approved these changes
Feb 21, 2025
SamWilsn
reviewed
Feb 25, 2025
ERCS/erc-XXXX.md
Outdated
| @@ -0,0 +1,481 @@ | |||
| --- | |||
| eip: XXXX | |||
There was a problem hiding this comment.
Assigned in OffchainLabs#1
assets/erc-XXXX/BHP.png
Outdated
There was a problem hiding this comment.
We have a slight preference for SVG diagrams, but if you cannot provide them, PNG is fine too.
SamWilsn
reviewed
Mar 13, 2025
ERCS/erc-7888.md
Outdated
|
|
||
| Since the ERC only uses finalized blocks, messages may take a long time to propagate between chains. Finalisation occurs sequentially in the route, therefore time to read a message is the sum of the finalisation of each of the block hashes at each step in the route. | ||
|
|
||
| ## Example: Publisher and Subscriber Burn and Mint Bridge |
There was a problem hiding this comment.
Suggested change
| ## Example: Publisher and Subscriber Burn and Mint Bridge | |
| ## Reference Implementation | |
| ### Example: Publisher and Subscriber Burn and Mint Bridge |
Perhaps?
There was a problem hiding this comment.
works for me, what do you think of also including IBroadcaster, IReceiver, IBlockHashProver and IBlockHashProverPointer contracts as well? https://github.com/OffchainLabs/broadcast-erc/tree/main/contracts/reference-impl
SamWilsn
reviewed
Mar 13, 2025
ERCS/erc-7888.md
Outdated
| The Broadcaster does not accept duplicate messages from the same publisher. | ||
|
|
||
| <div align="center"> | ||
| <img src="../assets/erc-7888/broadcasting.svg" alt="Figure 1" style="width:30%"/> |
There was a problem hiding this comment.
style attributes aren't supported by our linter (yet).
|
The commit df83579 (as a parent of 7632686) contains errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a cross-chain broadcasting standard. The approach uses storage proofs to trustlessly verify state on other rollups.