Skip to content

Update ERC-6123: Feature/erc 6123 after settlement #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cfries
Copy link
Contributor

@cfries cfries commented Jan 27, 2025

The method afterTransfer has been renamed afterSettlement.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Jan 27, 2025

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Feature/erc 6123 after settlement Update ERC-6123: Feature/erc 6123 after settlement Jan 27, 2025
@eip-review-bot eip-review-bot enabled auto-merge (squash) January 27, 2025 21:31
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link

The commit ef093b7 (as a parent of 89e0b17) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Jan 27, 2025
@@ -262,13 +262,13 @@ The interface design and reference implementation are based on the following con

### State diagram of trade and process states

![image info](../assets/eip-6123/doc/sdc_trade_states.svg)
![image info](../assets/erc-6123/doc/sdc_trade_states.svg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes will break the rendered output.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants