Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-1363: Remove external links and useless references #75

Conversation

vittominacori
Copy link
Contributor

This PR is part of some changes I would like to make on ERC1363 to follow the modern EIP1 recommendation.

This PR:

  • Remove external links and useless references to other eips

Note that this PR will not pass the CI, because of many changes required by validator and that are not addressed here but will be addressed in other PR.

I.g. external links, broken link, new line after h1, etc.

Other PR will address other sections of ERC1363

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Oct 31, 2023

File ERCS/erc-1363.md

Requires 2 more reviewers from @axic, @gcolvin, @lightclient, @Pandapip1, @SamWilsn

@eip-review-bot eip-review-bot changed the title Remove external links and useless references Update ERC-1363: Remove external links and useless references Oct 31, 2023
@github-actions github-actions bot added the w-ci label Oct 31, 2023
Copy link

The commit 3e34d42 (as a parent of a4ba678) contains errors.
Please inspect the Run Summary for details.

@SamWilsn
Copy link
Collaborator

SamWilsn commented Jan 3, 2024

These changes are a bit more involved than we allow for final EIPs. I think the best option would be to open a new EIP with the updated content.

@SamWilsn SamWilsn closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants