Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC-1363: Fix created date. #66

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Update ERC-1363: Fix created date. #66

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a663821
Update erc-1363.md
SamWilsn Oct 30, 2023
7ddafcc
Merge branch 'master' into SamWilsn-patch-1
Pandapip1 Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ERCS/erc-1363.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
---

Check failure on line 1 in ERCS/erc-1363.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble is missing header(s): `description` 

error[preamble-req]: preamble is missing header(s): `description`
--> ERCS/erc-1363.md
 |
 |
 = help: see https://ethereum.github.io/eipw/preamble-req/
eip: 1363
title: Payable Token
author: Vittorio Minacori (@vittominacori)
discussions-to: https://github.com/ethereum/eips/issues/1363

Check failure on line 5 in ERCS/erc-1363.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

preamble header `discussions-to` should point to a thread on ethereum-magicians.org 

error[preamble-re-discussions-to]: preamble header `discussions-to` should point to a thread on ethereum-magicians.org
 --> ERCS/erc-1363.md:5:16
  |
5 | discussions-to: https://github.com/ethereum/eips/issues/1363
  |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required pattern was not matched
  |
  = info: the pattern in question: `^https://ethereum-magicians.org/t/[^/]+/[0-9]+$`
  = help: see https://ethereum.github.io/eipw/preamble-re-discussions-to/
status: Final
type: Standards Track
category: ERC
created: 2020-01-31
created: 2018-08-30
requires: 20, 165
---

## Simple Summary

Check failure on line 13 in ERCS/erc-1363.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

body has extra section(s) 

error[markdown-order-section]: body has extra section(s)
  --> ERCS/erc-1363.md
   |
13 | ## Simple Summary
   |
   = help: see https://ethereum.github.io/eipw/markdown-order-section/
Defines a token interface for [ERC-20](./eip-20.md) tokens that supports executing recipient code after `transfer` or `transferFrom`, or spender code after `approve`.

## Abstract
Expand Down Expand Up @@ -195,14 +195,14 @@
The choice to use `transferAndCall`, `transferFromAndCall` and `approveAndCall` derives from the [ERC-20](./eip-20.md) naming. They want to highlight that they have the same behaviours of `transfer`, `transferFrom` and `approve` with the addition of a callback on receiver or spender.

## Backwards Compatibility
This proposal has been inspired also by [ERC-223](https://github.com/ethereum/EIPs/issues/223) and [ERC-677](https://github.com/ethereum/EIPs/issues/677) but it uses the [ERC-721](./eip-721.md) approach, so it doesn't override the [ERC-20](./eip-20.md) `transfer` and `transferFrom` methods and defines the interfaces IDs to be implemented maintaining the [ERC-20](./eip-20.md) backwards compatibility.

Check failure on line 198 in ERCS/erc-1363.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

unable to read file `erc-677.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'ERCS/erc-677.md' Error: ENOENT: no such file or directory, open 'ERCS/erc-677.md') 

error[markdown-refs]: unable to read file `erc-677.md`: Io: JsValue(Error: ENOENT: no such file or directory, open 'ERCS/erc-677.md'
Error: ENOENT: no such file or directory, open 'ERCS/erc-677.md')
   --> ERCS/erc-1363.md
    |
198 | This proposal has been inspired also by [ERC-223](https://github.com/ethereum/EIPs/issues/223) and [ERC-677](https://github.com/ethereum/EIPs/issues/677) but it uses the [ERC-721](./eip-721.md) approach, so it doesn't override the [ERC-20](./eip-20.md) `transfer` and `transferFrom` methods and defines the interfaces IDs to be implemented maintaining the [ERC-20](./eip-20.md) backwards compatibility.  
    |
    = help: see https://ethereum.github.io/eipw/markdown-refs/

Check failure on line 198 in ERCS/erc-1363.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

non-relative link or image 

error[markdown-rel-links]: non-relative link or image
   --> ERCS/erc-1363.md
    |
198 | This proposal has been inspired also by [ERC-223](https://github.com/ethereum/EIPs/issues/223) and [ERC-677](https://github.com/ethereum/EIPs/issues/677) but it uses the [ERC-721](./eip-721.md) approach, so it doesn't override the [ERC-20](./eip-20.md) `transfer` and `transferFrom` methods and defines the interfaces IDs to be implemented maintaining the [ERC-20](./eip-20.md) backwards compatibility.  
    |
    = help: see https://ethereum.github.io/eipw/markdown-rel-links/

Check failure on line 198 in ERCS/erc-1363.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

non-relative link or image 

error[markdown-rel-links]: non-relative link or image
   --> ERCS/erc-1363.md
    |
198 | This proposal has been inspired also by [ERC-223](https://github.com/ethereum/EIPs/issues/223) and [ERC-677](https://github.com/ethereum/EIPs/issues/677) but it uses the [ERC-721](./eip-721.md) approach, so it doesn't override the [ERC-20](./eip-20.md) `transfer` and `transferFrom` methods and defines the interfaces IDs to be implemented maintaining the [ERC-20](./eip-20.md) backwards compatibility.  
    |

## Security Considerations
The `approveAndCall` and `transferFromAndCall` methods can be affected by the same issue of the standard [ERC-20](./eip-20.md) `approve` and `transferFrom` method.

Changing an allowance with the `approveAndCall` methods brings the risk that someone may use both the old and the new allowance by unfortunate transaction ordering.

One possible solution to mitigate this race condition is to first reduce the spender's allowance to 0 and set the desired value afterwards ([EIP-20#issuecomment-263524729](https://github.com/ethereum/EIPs/issues/20#issuecomment-263524729)).

Check failure on line 205 in ERCS/erc-1363.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

references to proposals with a `category` of `ERC` must use a prefix of `ERC` 

error[markdown-refs]: references to proposals with a `category` of `ERC` must use a prefix of `ERC`
   --> ERCS/erc-1363.md
    |
205 | One possible solution to mitigate this race condition is to first reduce the spender's allowance to 0 and set the desired value afterwards ([EIP-20#issuecomment-263524729](https://github.com/ethereum/EIPs/issues/20#issuecomment-263524729)).
    |

Check failure on line 205 in ERCS/erc-1363.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

non-relative link or image 

error[markdown-rel-links]: non-relative link or image
   --> ERCS/erc-1363.md
    |
205 | One possible solution to mitigate this race condition is to first reduce the spender's allowance to 0 and set the desired value afterwards ([EIP-20#issuecomment-263524729](https://github.com/ethereum/EIPs/issues/20#issuecomment-263524729)).
    |

## Copyright
Copyright and related rights waived via [CC0](../LICENSE.md).
Loading