Update ERC-7208: Move to Review #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>
erc-7208 update: removed todo erc-7208 update: update metadata provider interface erc-7208 update: add mutation types
ERC7208:update Abstract ERC7208:update Motivation ERC7208:update interfaces ERC7208:update rationale ERC7208:update grammar ERC7208:update assets ERC7208:update reference implementation ERC7208:update removed erc721 dependency ERC7208:update fix comment ERC7208:update fixes to interfaces ERC7208:update fixes to interfaces ERC7208:update fixes to interfaces ERC7208:update fixes to rationale ERC7208:update fixes to implementation
erc7208 update: grammar fix erc7208 update: grammar fix
eip-review-bot
previously approved these changes
Aug 28, 2024
This reverts commit 6ef9a27.
auto-merge was automatically disabled
August 28, 2024 18:47
Head branch was pushed to by a user without write access
18 tasks
SamWilsn
requested changes
Sep 3, 2024
ERCS/erc-7208.md
Outdated
| @@ -271,6 +271,8 @@ We present an **educational example** implementation showcasing two types of tok | |||
| **This example has not been audited and should not be used in production environments.** | |||
|
|
|||
|
|
|||
| See [Minimalistic Data Index](https://github.com/NexeraProtocol/Minimalistic-Data-Index) implementation. | |||
There was a problem hiding this comment.
The linter is correct here. For the reasons enumerated here, please remove this external link.
There was a problem hiding this comment.
Hi @SamWilsn ,
I've removed the external link replacing it with the link to README.md, as you've suggested in the comment above.
But now the HTML prufer fails with
For the Links > Internal check, the following failures were found:
* At ./_site/EIPS/eip-7208.html:526:
internally linking to ../assets/erc-7208/contracts/README.md, which does not exist
HTML-Proofer found 1 failure!
which was the reason we've tried with external repo.
Do you have any ideas how to fix it?
… repository" This reverts commit a3d3ee7.
|
The commit f9c65e8 (as a parent of 01887ab) contains errors. |
9 tasks
SamWilsn
reviewed
Sep 17, 2024
ERCS/erc-7208.md
Outdated
| @@ -271,6 +271,8 @@ We present an **educational example** implementation showcasing two types of tok | |||
| **This example has not been audited and should not be used in production environments.** | |||
|
|
|||
|
|
|||
| See [contracts](../assets/erc-7208/contracts/README.md) | |||
There was a problem hiding this comment.
Because of a quirk of our rendering system, this needs to be:
Suggested change
| See [contracts](../assets/erc-7208/contracts/README.md) | |
| See [contracts](../assets/eip-7208/contracts/README.md) |
SamWilsn
approved these changes
Sep 25, 2024
eip-review-bot
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We request to push ERC-7208 to Review and Last Call soon, after validating with the community actively using this architecture.
Additionally, we provide an educational implementation that acts as a reference to the interoperability capabilities of this approach.