Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Multiplicative Tokens #50

Merged
merged 6 commits into from
Jan 9, 2024

Conversation

Pandapip1
Copy link
Member

Migration from ethereum/EIPs#7873

@github-actions
Copy link

The commit 4f8cb6d (as a parent of d035b02) contains errors.
Please inspect the Run Summary for details.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Oct 30, 2023

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title Add EIP: Multiplicative Tokens Add ERC: Multiplicative Tokens Oct 30, 2023
@github-actions github-actions bot removed the w-ci label Oct 30, 2023
@sullof
Copy link
Contributor

sullof commented Oct 31, 2023

@Pandapip1 I wonder why this PR passes the automatic checks, while all the others have issue with files other than the files in the PR. Any suggestion?


The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and "OPTIONAL" in this document are to be interpreted as described in RFC 2119 and RFC 8174.

The `MultiplierMetadata` interface MUST be implemented in the resolved ERC-1046 `tokenURI` of tokens that use a `multiplier`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `MultiplierMetadata` interface MUST be implemented in the resolved ERC-1046 `tokenURI` of tokens that use a `multiplier`:
The `MultiplierMetadata` interface MUST be implemented in the resolved [ERC-1046](./erc-1046.md) `tokenURI` of tokens that use a `multiplier`:


## Abstract

This EIP extends [ERC-1046](./eip-1046.md)-compatible token types (notably, [ERC-20](./eip-20.md) and [ERC-1155](./eip-1155.md) by introducing a `multiplier` field to the metadata schema, altering how user-facing balances are displayed.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This EIP extends [ERC-1046](./eip-1046.md)-compatible token types (notably, [ERC-20](./eip-20.md) and [ERC-1155](./eip-1155.md) by introducing a `multiplier` field to the metadata schema, altering how user-facing balances are displayed.
This EIP extends [ERC-1046](./erc-1046.md)-compatible token types (notably, [ERC-20](./erc-20.md) and [ERC-1155](./erc-1155.md) by introducing a `multiplier` field to the metadata schema, altering how user-facing balances are displayed.

Copy link
Collaborator

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough as draft

@eip-review-bot eip-review-bot enabled auto-merge (squash) November 2, 2023 04:07
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@github-actions github-actions bot removed the w-stale label Dec 19, 2023
Copy link

github-actions bot commented Jan 3, 2024

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@eip-review-bot eip-review-bot enabled auto-merge (squash) January 9, 2024 15:40
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@Pandapip1 Pandapip1 merged commit 198c7e4 into master Jan 9, 2024
9 of 10 checks passed
@Pandapip1 Pandapip1 deleted the Pandapip1-eip-multiplicative-tokens branch January 9, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants