-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ERC-1363: Update ERC-1363 to follow EIP-1 recommendation #31
Update ERC-1363: Update ERC-1363 to follow EIP-1 recommendation #31
Conversation
…date-erc1363-to-modern-recommendation
@SamWilsn moved the PR here. It still continue fail ci but not for the code added by me. Is there something I can do to solve that issue? |
…date-erc1363-to-modern-recommendation
File
|
The commit b106695 (as a parent of 5f2d25e) contains errors. |
Still cannot understand how to fix that ci issue. |
@vittominacori the CI is still a bit broken from splitting the repositories. Not your fault. We can override the bots. |
Final proposals cannot be edited, apart from errata (like the created date) or adding clarifications that don't change the behaviour of the standard. This pull request is changing a lot. Too much really. If you'd like to update to the latest formatting guidelines, do that in a separate pull request from any content changes. If you do want to make any content changes (errata or clarifications), keep them as small and simple as possible. For my own sanity, I'm going to be closing pull requests aggressively on this repository. Please don't take that to mean we don't value your contribution. Always feel free to re-open a pull request if you think it has been closed prematurely. Thanks! |
Ok thanks. I know it could seem that the whole EIP was changed but the most are changes required by validator. I will change one section at a time and PR also if it won't pass the CI (to pass I must edit all the sections again). |
This PR wants to only update EIP content in order to follow the most updated recommendation from EIP-1.
EIP-N
format.Former ethereum/EIPs#7877