Add EIP: Emit log on revert #9390
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-new
File
|
eth-bot
added
e-consensus
|
The commit d509968 (as a parent of 5609fb5) contains errors. |
bomanaps
reviewed
Feb 21, 2025
|
|
||
| ## Motivation | ||
|
|
||
| Revert messages are currently are inaccessible to users as they are not available via standard RPC. Instead users have to request a node to trace the transaction and check the stack and memory at the moment when the REVERT opcode was executed. |
There was a problem hiding this comment.
Suggested change
| Revert messages are currently are inaccessible to users as they are not available via standard RPC. Instead users have to request a node to trace the transaction and check the stack and memory at the moment when the REVERT opcode was executed. | |
| Revert messages are currently inaccessible to users as they are not available via standard RPC. Instead, users have to request a node to trace the transaction and check the stack and memory at the moment when the REVERT opcode was executed. |
|
|
||
| Revert messages are currently are inaccessible to users as they are not available via standard RPC. Instead users have to request a node to trace the transaction and check the stack and memory at the moment when the REVERT opcode was executed. | ||
|
|
||
| This introduces overhead for users and nodes - the user must make an additional request to find out why their transaction failed, and the node has to replay the full transaction (which may be slow and computationally expensive) to get back a relatively small piece of data. |
There was a problem hiding this comment.
Suggested change
| This introduces overhead for users and nodes - the user must make an additional request to find out why their transaction failed, and the node has to replay the full transaction (which may be slow and computationally expensive) to get back a relatively small piece of data. | |
| This introduces overhead for users and nodes - users must make an additional request to find out why their transaction failed, and the node has to replay the full transaction (which may be slow and computationally expensive) to get back a relatively small piece of data. |
Comment on lines
+36
to
+38
| ## Rationale | ||
|
|
||
| This is the simples possible implementation that allows revert messages to be accessible via RPC. |
There was a problem hiding this comment.
Your sentence introduces the idea well, but it could be strengthened by providing more justification. If the goal is to explain why revert messages should be accessible via RPC, consider expanding on why this implementation is preferable. For example, highlighting its efficiency, ease of integration, or benefits for developers would make the rationale more compelling.
Suggested change
| ## Rationale | |
| This is the simples possible implementation that allows revert messages to be accessible via RPC. | |
| ## Rationale | |
| This is the simplest possible implementation that allows revert messages to be accessible via RPC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to emit a log containing the revert message for reverted transactions, making it accessible via standard RPC without the need for tracing.