Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: On-chain upgrade signaling #9174

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

fulldecent
Copy link
Contributor

Ready for draft, please

@fulldecent fulldecent requested a review from eth-bot as a code owner December 22, 2024 08:36
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Dec 22, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Dec 22, 2024

File EIPS/eip-7848.md

Requires 1 more reviewers from @g11tech, @lightclient, @SamWilsn

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Dec 22, 2024
@eth-bot eth-bot changed the title Create eip-xxxx.md Add EIP: On-chain upgrade signaling Dec 22, 2024
Copy link

The commit 6ff93a5 (as a parent of fb9bdfb) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Dec 22, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Dec 23, 2024
@g11tech
Copy link
Contributor

g11tech commented Dec 23, 2024

not sure if this proposal is relevant to eth cc @SamWilsn as we may never go down this path

@fulldecent
Copy link
Contributor Author

Relevance should be based on whether this is an implementable proposal and if I can be heard.

Hopefully it is and this can be merged as DRAFT.

And then LATER, a stricter test is whether to implement this.

EIPS/eip-9174.md Outdated Show resolved Hide resolved
EIPS/eip-9174.md Outdated Show resolved Hide resolved
EIPS/eip-9174.md Outdated
@@ -0,0 +1,144 @@
---
eip: 9174
title: On-chain upgrade signaling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: On-chain upgrade signaling
title: Onchain upgrade signaling

I am not an editor. My personal preference is onchain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well noted.

At this point, on-chain is the preferred usage across other publications in this repo.

I'm happy to adopt the less common usage if we can point to it as a best practice.

And either way that should be after merging this as draft.

fulldecent and others added 2 commits December 23, 2024 19:52
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
EIPS/eip-9174.md Outdated Show resolved Hide resolved
@fulldecent
Copy link
Contributor Author

@g11tech requesting a merge for PR please so this can be discussed as draft

@fulldecent
Copy link
Contributor Author

Hi @g11tech, will you be blocking discussion on this draft, or may it please proceed to draft status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants