Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: GETCONTRACT opcode #8935

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Conversation

peersky
Copy link

@peersky peersky commented Oct 7, 2024

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@peersky peersky requested a review from eth-bot as a code owner October 7, 2024 14:41
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Oct 7, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 7, 2024

File EIPS/eip-7784.md

Requires 1 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Oct 7, 2024
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Oct 7, 2024
@eth-bot eth-bot changed the title Add EIP: GETCONTRACT opcode Add EIP: GETCONTRACT opcode Oct 7, 2024
EIPS/eip-xxxx.md Outdated Show resolved Hide resolved
EIPS/eip-xxxx.md Outdated Show resolved Hide resolved
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Copy link

github-actions bot commented Oct 8, 2024

The commit 9953f0e (as a parent of 0dc46b7) contains errors.
Please inspect the Run Summary for details.

EIPS/eip-xxxx.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Oct 10, 2024
* **Input:**
* `codehash`: A single 32-byte code hash from the stack.
* **Output:**
* `address`: If the `codehash` exists in the state, pushes the corresponding contract address onto the stack. Otherwise, pushes 0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if there are multiple addresses with same deployed code?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EVM should always return first indexed address.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is specified in the end of specification section as well as rationale for such decision is given later.

EIPS/eip-7784.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants