Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-2982: fix table displaying error #8607

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

cocoyeal
Copy link
Contributor

@cocoyeal cocoyeal commented May 29, 2024

Before:

image

After:

image

@cocoyeal cocoyeal requested a review from eth-bot as a code owner May 29, 2024 12:07
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-informational labels May 29, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented May 29, 2024

File EIPS/eip-2982.md

Requires 1 more reviewers from @djrtwo, @vbuterin
Requires 3 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label May 29, 2024
@eth-bot eth-bot changed the title fix table displaying error in eip2982 Update EIP-2982: fix table displaying error in eip2982 May 29, 2024
@cocoyeal cocoyeal changed the title Update EIP-2982: fix table displaying error in eip2982 Update EIP-2982: fix table displaying error May 29, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 29, 2024
Copy link

The commit 48c697f (as a parent of 3c97fd2) contains errors.
Please inspect the Run Summary for details.

@bumblefudge
Copy link
Contributor

This makes the relevant table more conformant/proper markdown but I think it's rendering OK as-is in some browsers?
Chrome:
image
Edge:
image
Firefox:
image

@xinbenlv
Copy link
Contributor

xinbenlv commented Jun 5, 2024

Hi thank you @cocoyeal this is xinbenlv an EIP editor here. We discussed this on ethcatherders/EIPIP#337 but it seems there is no rendering issue as shown by #8607 (comment). I think we can close this PR unless @cocoyeal can provide instruction to reproduce the issue.

@bumblefudge
Copy link
Contributor

image

OP is correct that the Github markdown renderer is stricter than what the browsers are doing, not sure if that's important to the EIP editors, tho?

@cocoyeal
Copy link
Contributor Author

cocoyeal commented Jun 6, 2024

@xinbenlv @bumblefudge Hi sir, yes, the rendering issue occurs to the EIP file on Github, as my original screenshot shows.

@g11tech
Copy link
Contributor

g11tech commented Jun 11, 2024

@xinbenlv @bumblefudge Hi sir, yes, the rendering issue occurs to the EIP file on Github, as my original screenshot shows.

the problem is other fixes need to be applied to the EIP for the CI to pass since CI rules have changed since this EIP was added

@SamWilsn SamWilsn merged commit 4fb310b into ethereum:master Jun 19, 2024
15 of 22 checks passed
@SamWilsn
Copy link
Contributor

Merged since this shouldn't be controversial and only affect formatting.

blacksnow2 pushed a commit to blacksnow2/EIPs that referenced this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-informational w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants