EIP-721 Non-Fungible Token Standard #841
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,9 +47,8 @@ pragma solidity ^0.4.20; | |
| import "./ERC165.sol"; | ||
|
|
||
| /// @title Required part of ERC-721 Distinguishable Assets Registry | ||
| /// @dev See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-721.md | ||
| /// Note: the ERC-165 identifier for this interface is 0xb3a99827 | ||
| interface ERC721 /* is ERC165 */ { | ||
| /// @dev This emits when ownership of any asset changes by any mechanism. | ||
| /// This event emits when assets are created (`from` == 0) and destroyed | ||
|
|
@@ -121,7 +120,7 @@ interface ERC721 /* is ERC165 */ { | |
| /// @param _approved True to appove an operators, false to revoke approval | ||
| function setApprovalForAll(address _operateor, boolean _approved) payable; | ||
|
|
||
| // CONFORMANCE TO ERC-165 ////////////////////////////////////////////////// | ||
|
|
||
| /// @notice Query if this implements an interface | ||
| /// @param interfaceID The interface identifier, as specified in ERC-165 | ||
|
|
@@ -137,9 +136,8 @@ The **metadata extension** is OPTIONAL for ERC-721 implementations (see "caveats | |
|
|
||
| ```solidity | ||
| /// @title Optional metadata extension to ERC-721 Distinguishable Assets Registry | ||
| /// @dev See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-721.md | ||
| /// Note: the ERC-165 identifier for this interface is 0x2a786f11 | ||
| interface ERC721Metadata /* is ERC721 */ { | ||
| /// @notice A descriptive name for a collection of assets in this contract | ||
| function name() external pure returns (string _name); | ||
|
|
@@ -163,15 +161,15 @@ This is the "ERC721 Metadata JSON Schema" referenced above. Learn more about [JS | |
| "type": "object", | ||
| "properties": { | ||
| "name": { | ||
| "type": "string", | ||
| "description": "Identifies the asset to which the DAR grants ownership", | ||
| }, | ||
| "description": { | ||
| "type": "string", | ||
| "description": "Describes the asset to which the DAR grants ownership", | ||
| }, | ||
| "image": { | ||
| "type": "string", | ||
| "description": "A URI pointing to a resource with mime type image/* representing the asset to which the DAR grants ownership. Consider making any images at a width between 320 and 1080 pixels and aspect ratio between 1.91:1 and 4:5 inclusive.", | ||
| } | ||
| } | ||
|
|
@@ -182,9 +180,8 @@ The **enumeration extension** is OPTIONAL for ERC-721 implementations (see "cave | |
|
|
||
| ```solidity | ||
| /// @title Optional enumeration extension to ERC-721 Distinguishable Assets Registry | ||
| /// @dev See https://github.com/ethereum/EIPs/blob/master/EIPS/eip-721.md | ||
| /// Note: the ERC-165 identifier for this interface is 0x5576ab6a | ||
| interface ERC721Enumerable /* is ERC721 */ { | ||
| /// @notice Count assets tracked by this contract | ||
| /// @return A count of valid assets tracked by this contract, where each one of | ||
|
|
@@ -228,7 +225,7 @@ interface ERC721Enumerable /* is ERC721 */ { | |
|
|
||
| The 0.4.20 Solidity interface grammar is not expressive enough to document the ERC-721 specification. A contract which complies with ERC-721 MUST also abide by the following: | ||
|
|
||
| - [Solidity issue #3412](https://github.com/ethereum/solidity/issues/3412): The above interfaces include explicit mutability guarantees for each function. Mutability guarantees are, in order weak to strong: `payable`, implicit nonpayable, `view`, and `pure`. Your implementation must meet the mutability guarantee in this interface or you may meet a stronger guarantee. For example, a `payable` function in this interface may be implemented as nonpayble (no state mutability specified) in your contract. We expect a later Solidity release will allow your stricter contract to inherit from this interface, but a workaround for version 0.4.20 is that you can edit this interface to add stricter mutability before inheriting from your contract. | ||
| - [Solidity issue #3419](https://github.com/ethereum/solidity/issues/3419): A contract that implements `ERC721Metadata` or `ERC721Enumerable` SHALL also implement `ERC721`. ERC-721 implements the requirements of interface [ERC-165](https://github.com/ethereum/EIPs/pull/881). | ||
| - [Solidity issue #2330](https://github.com/ethereum/solidity/issues/2330): If a function is shown in this specification as `external` then a contract will be compliant if it uses `public` visibility. | ||
| - Solidity issues [#3494](https://github.com/ethereum/solidity/issues/3494), [#3544](https://github.com/ethereum/solidity/issues/3544): Use of `this.*.selector` is marked as a warning by Solidity, a future version of Solidity will not mark this as an error. | ||
|
There was a problem hiding this comment. ethereum/solidity#3494 seems to have already been fixed |
||
|
|
@@ -287,9 +284,9 @@ Creating of new assets and destruction of assets is not included in the specific | |
|
|
||
| **ERC-165 interface** | ||
|
|
||
| This specification includes a function `supportsInterface` which is standardized in [ERC-165](https://github.com/ethereum/EIPs/pull/881). So any contract MAY query your contract to see if it complies with ERC-721 and the extensions. | ||
|
|
||
| A future EIP may create a global registry of interfaces for contracts. We strongly support such an EIP and it would allow your contract to to implement ERC721Enumerable, ERC721Metadata, or other interfaces by delegating to a separate contract. | ||
|
|
||
| **Gas and complexity** (regarding the enumeration extension) | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ERC-165has been merged and can be referenced with https://github.com/ethereum/EIPs/blob/master/EIPS/eip-165.md