Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: Precompile Falcon512 generic verifier #8190

Closed
wants to merge 19 commits into from
Closed

Add EIP: Precompile Falcon512 generic verifier #8190

wants to merge 19 commits into from
+12,073 −0

Conversation

eum602
Copy link

@eum602 eum602 commented Feb 9, 2024 •
edited
Loading

Propose to add a generic Postquantum signature verification algorithm based on Falcon-512.

@eum602 eum602 requested a review from eth-bot as a code owner February 9, 2024 02:58
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Feb 9, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Feb 9, 2024 •
edited
Loading

File EIPS/eip-7619.md

Requires 1 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Feb 9, 2024
@eth-bot eth-bot changed the title Falcon signature precompiled Add EIP: Add Precompile for Falcon512 post-quantum signature verification function Feb 9, 2024
abcoathup
abcoathup reviewed Feb 9, 2024
View reviewed changes
EIPS/eip-7213.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Feb 9, 2024
@abcoathup
Copy link
Contributor

There is already draft EIP7592: Precompile for Falcon Signature Verification
https://github.com/ethereum/EIPs/pull/8103/files

You may want to combine efforts for a Falcon signature verification precompile.

@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Feb 9, 2024
@eth-bot eth-bot changed the title Add EIP: Add Precompile for Falcon512 post-quantum signature verification function Add EIP: Precompile Falcon512 generic verifier Feb 9, 2024
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Feb 9, 2024
abcoathup
abcoathup reviewed Feb 9, 2024
View reviewed changes
EIPS/eip-7213.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Feb 9, 2024
gaudren
gaudren reviewed Feb 12, 2024
View reviewed changes
EIPS/eip-7619.md Outdated Show resolved Hide resolved
EIPS/eip-7619.md Outdated Show resolved Hide resolved
EIPS/eip-7619.md Outdated Show resolved Hide resolved
EIPS/eip-7619.md Outdated Show resolved Hide resolved
EIPS/eip-7619.md Outdated Show resolved Hide resolved
EIPS/eip-7619.md Show resolved Hide resolved
EIPS/eip-7619.md Outdated Show resolved Hide resolved
EIPS/eip-7619.md Outdated Show resolved Hide resolved
EIPS/eip-7619.md Show resolved Hide resolved
EIPS/eip-7619.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added c-update Modifies an existing proposal t-process labels Feb 19, 2024
@eth-bot eth-bot changed the title Add EIP: Precompile Falcon512 generic verifier Update EIP-1: Precompile Falcon512 generic verifier Feb 19, 2024
eum602 and others added 8 commits February 19, 2024 13:48
@eum602
EIP-7213: Falcon Signature verification
39a0f9c
@eum602
EIP-7213: Falcon Signature verification test vectors and interface up…
89a5d08 
…dates
@eum602
docs: update docs
fcc84e0 
Signed-off-by: eum602 <eum602@gmail.com>
@eum602
update link for discussions
0f15bcf 
Signed-off-by: eum602 <eum602@gmail.com>
@eum602 @abcoathup
Update EIPS/eip-7213.md
1f63e3a 
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
@eum602
fix format errors
e195b86 
Signed-off-by: eum602 <eum602@gmail.com>
@eum602
remove external links
ee9a4ed 
Signed-off-by: eum602 <eum602@gmail.com>
@eum602
fix eip validator triggered errors
e9b9e95 
Signed-off-by: eum602 <eum602@gmail.com>
@eum602
EIP-7619: revert modifications to EIP-1
0702f1d 
Signed-off-by: eum602 <eum602@gmail.com>
@github-actions github-actions bot removed c-update Modifies an existing proposal t-process labels Feb 19, 2024
@eth-bot eth-bot changed the title Update EIP-1: Precompile Falcon512 generic verifier Add EIP: Precompile Falcon512 generic verifier Feb 19, 2024
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Feb 19, 2024
@eum602 eum602 mentioned this pull request Feb 19, 2024
Closed
@SamWilsn SamWilsn mentioned this pull request Feb 19, 2024
Closed
@SamWilsn
Copy link
Contributor

It looks like the implementation of Falcon is MIT licensed: https://github.com/PQClean/PQClean/blob/master/crypto_sign/falcon-512/clean/LICENSE

You could copy that directory into ../assets/eip-7619/ and link to it from your proposal.

@eum602
Copy link
Author

eum602 commented Mar 13, 2024

It looks like the implementation of Falcon is MIT licensed: https://github.com/PQClean/PQClean/blob/master/crypto_sign/falcon-512/clean/LICENSE

You could copy that directory into ../assets/eip-7619/ and link to it from your proposal.

Thank you will do that way @SamWilsn

@eum602
Add PQClean falcon512 implementation
bee79f3 
Signed-off-by: eum602 <eum602@gmail.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2024

The commit bee79f3 (as a parent of 780aee0) contains errors.
Please inspect the Run Summary for details.

@eum602
Rename file to avoid code spelling errors
7f1456d 
Signed-off-by: eum602 <eum602@gmail.com>
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label May 5, 2024
@eum602
Copy link
Author

eum602 commented May 5, 2024

It looks like the implementation of Falcon is MIT licensed: https://github.com/PQClean/PQClean/blob/master/crypto_sign/falcon-512/clean/LICENSE

You could copy that directory into ../assets/eip-7619/ and link to it from your proposal.

Done @SamWilsn , the implementation was added in assets/eip-7619 . All checks have passed

@github-actions GitHub Actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label May 20, 2024
@eum602
Copy link
Author

eum602 commented May 20, 2024 •
edited
Loading

I have addressed all required feedback and am ready for a review.

@github-actions github-actions bot removed the w-stale Waiting on activity label May 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added w-stale Waiting on activity and removed w-stale Waiting on activity labels Jun 4, 2024
@g11tech
Copy link
Contributor

g11tech commented Jun 11, 2024

everything else looks good i am not sure if we would want huge implementation and testvectors in the EIP assets. what do you think @SamWilsn

@github-actions GitHub Actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jun 26, 2024
@poojaranjan poojaranjan mentioned this pull request Jul 3, 2024
Closed
18 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Aug 7, 2024
@eum602
Copy link
Author

eum602 commented Aug 7, 2024

Is there anything else we can do to move this PR to the next step?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcoathup abcoathup abcoathup left review comments

@g11tech g11tech g11tech left review comments

@gaudren gaudren gaudren left review comments

@neri-lacnet neri-lacnet neri-lacnet left review comments

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core w-stale Waiting on activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@eum602 @eth-bot @abcoathup @SamWilsn @g11tech @gaudren @neri-lacnet