-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Add EIP-5453: Smart Contract Crypto Endorsement #5453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All tests passed; auto-merging...(pass) eip-5453.md
|
The commit 4881ce2 (as a parent of e58ef56) contains errors. Please inspect the Run Summary for details. |
The commit a64c92a (as a parent of 3f413ea) contains errors. Please inspect the Run Summary for details. |
The commit cc8e887 (as a parent of 04098ee) contains errors. Please inspect the Run Summary for details. |
EIPS/eip-5453.md
Outdated
## Test Cases | ||
TODO | ||
|
||
## Reference Implementation | ||
TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Test Cases | |
TODO | |
## Reference Implementation | |
TODO |
The commit e328237 (as a parent of d9cedfd) contains errors. Please inspect the Run Summary for details. |
The commit 9894c3b (as a parent of 3a5f26b) contains errors. Please inspect the Run Summary for details. |
Revised |
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xinbenlv I made a few minor changes that needed to be fixed. If you take issue with any of them, please submit a new PR that reverts them.
(FYI - I made them so that this EIP can be merged faster)
* Add ERC-endorse * Update filename * Update content * Update content * Update content * Update content * Update content * Update content * Update content * Update content * Update content * remove a security vulnerbility because bot doens\'t let me incude external link. * Update content * Update eip-5453.md * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update eip-5453.md * Update eip-5453.md * Update eip-5453.md * Update eip-5453.md * Update eip-5453.md * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update eip-5453.md * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update eip-5453.md * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update eip-5453.md * Update eip-5453.md * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5453.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Fix typo * Fix external link Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Add an ERC for on-chain endorsement.