Skip to content

Conversation

xinbenlv
Copy link
Contributor

Add an ERC for on-chain endorsement.

@eth-bot
Copy link
Collaborator

eth-bot commented Aug 12, 2022

All tests passed; auto-merging...

(pass) eip-5453.md

classification
updateEIP
  • passed!

@github-actions
Copy link

The commit 4881ce2 (as a parent of e58ef56) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

The commit a64c92a (as a parent of 3f413ea) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

The commit cc8e887 (as a parent of 04098ee) contains errors. Please inspect the Run Summary for details.

EIPS/eip-5453.md Outdated
Comment on lines 42 to 46
## Test Cases
TODO

## Reference Implementation
TODO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Test Cases
TODO
## Reference Implementation
TODO

@github-actions
Copy link

The commit e328237 (as a parent of d9cedfd) contains errors. Please inspect the Run Summary for details.

@github-actions
Copy link

The commit 9894c3b (as a parent of 3a5f26b) contains errors. Please inspect the Run Summary for details.

@xinbenlv
Copy link
Contributor Author

Revised

xinbenlv and others added 8 commits August 24, 2022 10:58
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
@Pandapip1 Pandapip1 changed the title EIP-5453: Smart Contract Crypto Endorsement Add EIP-5453: Smart Contract Crypto Endorsement Aug 28, 2022
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels Aug 28, 2022
Copy link
Member

@Pandapip1 Pandapip1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xinbenlv I made a few minor changes that needed to be fixed. If you take issue with any of them, please submit a new PR that reverts them.

(FYI - I made them so that this EIP can be merged faster)

@eth-bot eth-bot enabled auto-merge (squash) August 28, 2022 17:35
@eth-bot eth-bot merged commit 63febf2 into ethereum:master Aug 28, 2022
@xinbenlv xinbenlv deleted the erc-endorse branch October 4, 2022 01:56
nachomazzara pushed a commit to nachomazzara/EIPs that referenced this pull request Jan 13, 2023
* Add ERC-endorse

* Update filename

* Update content

* Update content

* Update content

* Update content

* Update content

* Update content

* Update content

* Update content

* Update content

* remove a security vulnerbility because bot doens\'t let me incude external link.

* Update content

* Update eip-5453.md

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update eip-5453.md

* Update eip-5453.md

* Update eip-5453.md

* Update eip-5453.md

* Update eip-5453.md

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update eip-5453.md

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update eip-5453.md

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update eip-5453.md

* Update eip-5453.md

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Update EIPS/eip-5453.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Fix typo

* Fix external link

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants