Client Script URI for Token Contracts #5169

JamesSmartCell · 2022-06-17T21:36:47Z

This ERC is a contract interface that adds a scriptURI() function for locating executable scripts associated with the token.

Full details in the EIP md file.

eth-bot · 2022-06-17T21:37:40Z

All tests passed; auto-merging...

(pass) eip-5169.md

classification
`updateEIP`

passed!

Pandapip1

Here's my first pass.

EIPS/eip-5169.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Pandapip1 · 2022-06-19T13:38:04Z

Just for future reference, if you go into the files tab of the PR, you can select any number of suggestions and batch commit them.

MicahZoltu

Missing Copyright section.

EIPS/eip-5169.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

EIPS/eip-5169.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Pandapip1

Please fix the relevant CI errors

JamesSmartCell · 2022-08-25T23:21:06Z

Please fix the relevant CI errors

EDIT: NVM, fixed, can view errors now :)

JamesSmartCell · 2022-08-25T23:38:26Z

@Pandapip1 I resolved the CI error where we point to EIP-5170 (which is still in the checking phase) by referring to it by title. If this subsequent EIP is approved then can EIP-5169 (this EIP) still be updated to link directly, assuming it passes?

Pandapip1

LGTM

Outdated

* Add client script EIP * fix submission error * update header * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update eip-5169.md * Update eip-5169.md * Update EIPS/eip-5169.md Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update eip-5169.md * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update eip-5169.md * Update eip-5169.md * Update eip-5169.md * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update eip-5169.md * Update eip-5169.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> Co-authored-by: lightclient <14004106+lightclient@users.noreply.github.com> Co-authored-by: Micah Zoltu <micah@zoltu.net>

Add client script EIP

d82c696

eth-bot added the ambiguous label Jun 17, 2022

JamesSmartCell added 2 commits June 18, 2022 09:12

fix submission error

f609b60

update header

7817198

eth-bot added newEIPFile and removed ambiguous labels Jun 18, 2022

Pandapip1 suggested changes Jun 18, 2022

View reviewed changes

JamesSmartCell and others added 12 commits June 19, 2022 14:12

Update EIPS/eip-5169.md

2cd0d2d

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5169.md

6c8470a

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5169.md

d502449

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5169.md

5caeddf

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5169.md

3defc58

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5169.md

d6eb93c

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5169.md

cccc004

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5169.md

063fd8a

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5169.md

a9cc35e

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5169.md

fc292ee

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update eip-5169.md

d8d28b7

Update eip-5169.md

f476679

MicahZoltu reviewed Jun 20, 2022

View reviewed changes

EIPS/eip-5169.md Outdated Show resolved Hide resolved

EIPS/eip-5169.md Show resolved Hide resolved

SamWilsn reviewed Jul 8, 2022

View reviewed changes

EIPS/eip-5169.md Outdated Show resolved Hide resolved

poojaranjan mentioned this pull request Jul 12, 2022

EIP editor apprenticeship meeting 21 ethcatherders/EIPIP#154

Closed

lightclient previously requested changes Jul 12, 2022

View reviewed changes

EIPS/eip-5169.md Outdated Show resolved Hide resolved

EIPS/eip-5169.md Show resolved Hide resolved

EIPS/eip-5169.md Outdated Show resolved Hide resolved

hboon mentioned this pull request Aug 3, 2022

Support scriptURI() smart contract call to retrieve URI for TokenScript files AlphaWallet/alpha-wallet-ios#5110

Closed

SamWilsn removed the newEIPFile label Aug 18, 2022

JamesSmartCell dismissed stale reviews from ghost via 61a2705 August 23, 2022 05:28

JamesSmartCell requested a review from eth-bot as a code owner August 23, 2022 05:28

JamesSmartCell and others added 4 commits August 24, 2022 12:00

Update EIPS/eip-5169.md

39e7082

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5169.md

75e7422

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5169.md

23cbabc

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update eip-5169.md

977c47a

github-actions bot removed the type: ERC label Aug 24, 2022

JamesSmartCell added 2 commits August 24, 2022 12:37

Update eip-5169.md

cd22d86

Update eip-5169.md

a69f438

Pandapip1 suggested changes Aug 24, 2022

View reviewed changes

EIPS/eip-5169.md Outdated Show resolved Hide resolved

EIPS/eip-5169.md Outdated Show resolved Hide resolved

EIPS/eip-5169.md Outdated Show resolved Hide resolved

Update EIPS/eip-5169.md

1794845

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

github-actions bot added the type: ERC label Aug 25, 2022

JamesSmartCell and others added 2 commits August 25, 2022 16:57

Update EIPS/eip-5169.md

46de631

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

Update EIPS/eip-5169.md

50a4b2d

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

github-actions bot added the waiting: htmlproofer to pass label Aug 25, 2022

JamesSmartCell mentioned this pull request Aug 25, 2022

draft new ERC for contract working with ts SmartTokenLabs/TokenScript#430

Draft

Pandapip1 suggested changes Aug 25, 2022

View reviewed changes

JamesSmartCell added 2 commits August 26, 2022 09:21

Merge branch 'master' into master

79b23ec

Update eip-5169.md

ad60873

github-actions bot removed the waiting: htmlproofer to pass label Aug 25, 2022

Update eip-5169.md

b21e492

Pandapip1 removed classification: new EIP labels Aug 26, 2022

Pandapip1 approved these changes Aug 26, 2022

View reviewed changes

eth-bot enabled auto-merge (squash) August 26, 2022 20:29

eth-bot approved these changes Aug 26, 2022

View reviewed changes

eth-bot merged commit b3c7159 into ethereum:master Aug 26, 2022

Client Script URI for Token Contracts #5169

Client Script URI for Token Contracts #5169

Uh oh!

Conversation

JamesSmartCell commented Jun 17, 2022

Uh oh!

eth-bot commented Jun 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

All tests passed; auto-merging...

(pass) eip-5169.md

Uh oh!

Pandapip1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pandapip1 commented Jun 19, 2022

Uh oh!

MicahZoltu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pandapip1 left a comment

Choose a reason for hiding this comment

Uh oh!

JamesSmartCell commented Aug 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JamesSmartCell commented Aug 25, 2022

Uh oh!

Pandapip1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eth-bot commented Jun 17, 2022 •

edited

Loading

JamesSmartCell commented Aug 25, 2022 •

edited

Loading