-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Update author format to preferred name + GitHub username format, Gavin #4560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s): (fail) EIPS/eip-161.md
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine from me, but probably @gavofyork should give a nod too.
@MicahZoltu @lightclient if you think this can merged as-is, please do. I think it should be fine as the author is identifyable, but this is a retroactive application of the EIP-1 rule if enforced by an editor. |
I am slightly less OK with this one versus the one for vbuterin because in the case of Vitalik, we have evidence that they are OK with their GitHub handle being associated with EIP authorship (based on their recent EIPs). I don't believe there are any EIPs authored by Gavin that include their handle though, so we don't have a good precedent for acceptability. That being said, it wouldn't be a significant doxxing of Gavin since as mentioned by @axic they are already well known and their GitHub handle is trivially easy to find (first result in an internet search for "Gavin Wood GitHub". @lightclient do you have thoughts on the matter? |
^ this is all the right points to bring up for this consideration. Now it's up to editors to decide based on the evidence |
It turns out this is the only EIP not having a username/email in the author line. If we can get this merged, we can have stronger rule enforcement: ethereum/eipv#39 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no issues with merging this as-is.
I think this is compelling enough to convince me, when combined with support from other editors. |
|
Updating EIPs from this author to use preferred author citation format.
REFERENCES: