Skip to content

Conversation

fulldecent
Copy link
Contributor

Updating EIPs from this author to use preferred author citation format.

REFERENCES:

@eth-bot
Copy link
Collaborator

eth-bot commented Dec 15, 2021

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) EIPS/eip-161.md

  • eip-161.md has no identifiable authors who can approve the PR (only considering the base version)

Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine from me, but probably @gavofyork should give a nod too.

@axic
Copy link
Member

axic commented Dec 15, 2021

@MicahZoltu @lightclient if you think this can merged as-is, please do. I think it should be fine as the author is identifyable, but this is a retroactive application of the EIP-1 rule if enforced by an editor.

@MicahZoltu
Copy link

I am slightly less OK with this one versus the one for vbuterin because in the case of Vitalik, we have evidence that they are OK with their GitHub handle being associated with EIP authorship (based on their recent EIPs). I don't believe there are any EIPs authored by Gavin that include their handle though, so we don't have a good precedent for acceptability.

That being said, it wouldn't be a significant doxxing of Gavin since as mentioned by @axic they are already well known and their GitHub handle is trivially easy to find (first result in an internet search for "Gavin Wood GitHub".

@lightclient do you have thoughts on the matter?

@fulldecent
Copy link
Contributor Author

^ this is all the right points to bring up for this consideration.

Now it's up to editors to decide based on the evidence

@axic
Copy link
Member

axic commented Dec 21, 2021

It turns out this is the only EIP not having a username/email in the author line. If we can get this merged, we can have stronger rule enforcement: ethereum/eipv#39

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no issues with merging this as-is.

@MicahZoltu
Copy link

It turns out this is the only EIP not having a username/email in the author line. If we can get this merged, we can have stronger rule enforcement: ethereum/eipv#39

I think this is compelling enough to convince me, when combined with support from other editors.

@axic
Copy link
Member

axic commented Feb 15, 2022

It turns out this is the only EIP not having a username/email in the author line. If we can get this merged, we can have stronger rule enforcement: ethereum/eipv#39
I think this is compelling enough to convince me, when combined with support from other editors.

Ah, we missed EIP-158 from @vbuterin also lacking a handle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants