2681: Few minor updates + move to review #3130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightclient
force-pushed
the
update-2681
branch
from
9aca9f3
to
c1d11b4
Compare
|
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
|
MicahZoltu
changed the title
axic
approved these changes
Nov 27, 2020
axic
reviewed
Nov 27, 2020
| @@ -42,21 +41,13 @@ This mode of replay protection is out of fashion since [EIP-155](./eip-155.md) i | |||
|
|
|||
| While this is a breaking change, no actual effect should be visible: | |||
|
|
|||
| 1. There is no account in the state currently which would have a nonce exceeding that value. **Need to double check, but would be very surprised.** | |||
| 1. There is no account in the state currently which would have a nonce exceeding that value. As of November 2020, the account `0xea674fdde714fd979de3edf0f56aa9716b898ec8` is responsible for the highest account nonce at approximately 29 million. | |||
There was a problem hiding this comment.
So are you saying this account spent at least 600 billion gas? 🤭
Arachnid
pushed a commit
to Arachnid/EIPs
that referenced
this pull request
Mar 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a couple minor updates to this EIP. The highest account nonce was found by querying the Google
crypto_ethereumdataset.I would like to bring this EIP up at ACD 101 for feedback, so I also went ahead and moved this EIP to review.