-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch validator to eipv #2860
Merged
Souptacular
merged 47 commits into
ethereum:master
from
lightclient:update-eip-validator
Aug 10, 2020
Merged
Switch validator to eipv #2860
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
bff86e3
switch to eipv
lightclient 533bb1a
fix
lightclient 0cbcc94
fix
lightclient f6aeded
1153 remove trailing whitespace
lightclient e25dd51
remove file name checks
lightclient 838d6a7
615 remo whitespace before comma
lightclient 531fc72
884 remove extra single-quotes
lightclient a04f6ae
1337 remove whitespace before comma
lightclient 315ae8a
1057 remove extra spaces after comma
lightclient e716f61
2470 update created date to Y/M/D format
lightclient 208dd1a
1078 update required eips to be in ascending order
lightclient 4ee9314
2477 update required eips to be in ascending order
lightclient f4219d8
1271 remove extra whitespace
lightclient 32ffc82
2767 required eipupdated to be in ascending order
lightclient 6643038
2525 update created date to Y/M/D format
lightclient 322db84
2458 remove trailing whitespace
lightclient 29ad8dc
1884 remove trailing whitespace
lightclient f7f4ff5
712 authors should be on a single line
lightclient c801d96
601 remove extra whitespace
lightclient ecc7481
1485 remove unneeded parentheses
lightclient cfc26d6
634 remove trailing whitespace
lightclient a853f50
2657 update discussions-to to correct spelling
lightclient 62b4896
2009 remove trailing whitespace
lightclient b88899c
998 required eips updated to be in ascending order
lightclient f066a78
1186 remove trailing whitespace
lightclient a41e4ae
1470 remove extra whitespace
lightclient db83eec
1895 update created date to Y/M/D format
lightclient 57c9e28
2747 remove extra whitespace
lightclient c3da24f
1613 remove leading whitespace
lightclient 64bc976
1571 can'have both handle and email in author field
lightclient d038a25
1191 remove trailing whitespace
lightclient 75986bd
1973 remove trailing whitespace
lightclient 39d6036
196 don't wrap title field
lightclient 4c7851a
1679 required eips must be in ascending order
lightclient 0fa9d62
1620 author can't have both handle and email
lightclient 3d2a8ac
197 don't line wrap title field
lightclient f48a465
2378 remove extra newline
lightclient 81e7d61
1355 author can't have both handle and email
lightclient 7a25c9b
698 update created date to Y/M/D format
lightclient 128404e
2193 required eips must be in ascending order
lightclient d274a9f
214 remove extra info after author email
lightclient 2da2916
use v0.0.3 of eipv
lightclient 87f75fc
1 remove malformed field
lightclient 89af85b
bump eipv to v0.0.4
lightclient 35da03e
cache eipv build
lightclient bb0d5b5
1485 remove extra author info
lightclient 45c06d4
2771 removing extra whitespaces
lightclient File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 remove malformed field
- Loading branch information
commit 87f75fc80ba5647a2591043011666280434df343
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear what purpose this URL served here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have changed this file locally just never submitted a PR. My understanding it tries to signal "look at the history".
What I opted for was "Martin ..., Hudson ..., et al."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, it was supposed to be a part of the authors field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the authors for EIP-1 to just "Contributors Like You". 🚎 /not-🚎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a strong feeling towards this, but IMO it's outside the scope of this PR.