Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch validator to eipv #2860

Merged
merged 47 commits into from
Aug 10, 2020
Merged
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
bff86e3
switch to eipv
lightclient Aug 6, 2020
533bb1a
fix
lightclient Aug 6, 2020
0cbcc94
fix
lightclient Aug 6, 2020
f6aeded
1153 remove trailing whitespace
lightclient Aug 6, 2020
e25dd51
remove file name checks
lightclient Aug 6, 2020
838d6a7
615 remo whitespace before comma
lightclient Aug 6, 2020
531fc72
884 remove extra single-quotes
lightclient Aug 6, 2020
a04f6ae
1337 remove whitespace before comma
lightclient Aug 6, 2020
315ae8a
1057 remove extra spaces after comma
lightclient Aug 6, 2020
e716f61
2470 update created date to Y/M/D format
lightclient Aug 6, 2020
208dd1a
1078 update required eips to be in ascending order
lightclient Aug 6, 2020
4ee9314
2477 update required eips to be in ascending order
lightclient Aug 6, 2020
f4219d8
1271 remove extra whitespace
lightclient Aug 6, 2020
32ffc82
2767 required eipupdated to be in ascending order
lightclient Aug 6, 2020
6643038
2525 update created date to Y/M/D format
lightclient Aug 6, 2020
322db84
2458 remove trailing whitespace
lightclient Aug 6, 2020
29ad8dc
1884 remove trailing whitespace
lightclient Aug 6, 2020
f7f4ff5
712 authors should be on a single line
lightclient Aug 6, 2020
c801d96
601 remove extra whitespace
lightclient Aug 6, 2020
ecc7481
1485 remove unneeded parentheses
lightclient Aug 6, 2020
cfc26d6
634 remove trailing whitespace
lightclient Aug 6, 2020
a853f50
2657 update discussions-to to correct spelling
lightclient Aug 6, 2020
62b4896
2009 remove trailing whitespace
lightclient Aug 6, 2020
b88899c
998 required eips updated to be in ascending order
lightclient Aug 6, 2020
f066a78
1186 remove trailing whitespace
lightclient Aug 6, 2020
a41e4ae
1470 remove extra whitespace
lightclient Aug 6, 2020
db83eec
1895 update created date to Y/M/D format
lightclient Aug 6, 2020
57c9e28
2747 remove extra whitespace
lightclient Aug 6, 2020
c3da24f
1613 remove leading whitespace
lightclient Aug 6, 2020
64bc976
1571 can'have both handle and email in author field
lightclient Aug 6, 2020
d038a25
1191 remove trailing whitespace
lightclient Aug 6, 2020
75986bd
1973 remove trailing whitespace
lightclient Aug 6, 2020
39d6036
196 don't wrap title field
lightclient Aug 6, 2020
4c7851a
1679 required eips must be in ascending order
lightclient Aug 6, 2020
0fa9d62
1620 author can't have both handle and email
lightclient Aug 6, 2020
3d2a8ac
197 don't line wrap title field
lightclient Aug 6, 2020
f48a465
2378 remove extra newline
lightclient Aug 6, 2020
81e7d61
1355 author can't have both handle and email
lightclient Aug 6, 2020
7a25c9b
698 update created date to Y/M/D format
lightclient Aug 6, 2020
128404e
2193 required eips must be in ascending order
lightclient Aug 6, 2020
d274a9f
214 remove extra info after author email
lightclient Aug 6, 2020
2da2916
use v0.0.3 of eipv
lightclient Aug 6, 2020
87f75fc
1 remove malformed field
lightclient Aug 6, 2020
89af85b
bump eipv to v0.0.4
lightclient Aug 6, 2020
35da03e
cache eipv build
lightclient Aug 6, 2020
bb0d5b5
1485 remove extra author info
lightclient Aug 7, 2020
45c06d4
2771 removing extra whitespaces
lightclient Aug 7, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
1 remove malformed field
  • Loading branch information
lightclient committed Aug 10, 2020
commit 87f75fc80ba5647a2591043011666280434df343
1 change: 0 additions & 1 deletion EIPS/eip-1.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ title: EIP Purpose and Guidelines
status: Active
type: Meta
author: Martin Becze <mb@ethereum.org>, Hudson Jameson <hudson@ethereum.org>, and others
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1.md
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear what purpose this URL served here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed this file locally just never submitted a PR. My understanding it tries to signal "look at the history".

What I opted for was "Martin ..., Hudson ..., et al."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, it was supposed to be a part of the authors field.

Copy link
Contributor

@MicahZoltu MicahZoltu Aug 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the authors for EIP-1 to just "Contributors Like You". 🚎 /not-🚎

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong feeling towards this, but IMO it's outside the scope of this PR.

created: 2015-10-27
updated: 2015-12-07, 2016-02-01, 2018-03-21, 2018-05-29, 2018-10-17, 2019-05-19, 2019-12-04, 2020-06-17
---
Expand Down