Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitwise shifting instructions in EVM #215

Merged
merged 12 commits into from
Sep 22, 2017
Merged

Bitwise shifting instructions in EVM #215

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4bab879
Draft of bitwise shifting opcodes
axic Feb 13, 2017
a63aef3
Remove ROR/ROL
axic Apr 23, 2017
0b34616
Add link to client support (cpp-ethereum)
axic Apr 23, 2017
7bc4477
Swap shift operands (value is the top item)
axic Apr 23, 2017
27847a8
Rename to EIP145
axic Apr 23, 2017
d4f5382
Clarify shift amount (arg2)
axic Apr 23, 2017
e5ca919
Use floor and not udiv/sdiv
axic Jul 3, 2017
4218665
Explain sign of arg1/arg2
axic Jul 3, 2017
0b08d11
Add comparison with current opcodes
axic Jul 31, 2017
9464fa7
Clarify text (user -> use)
axic Sep 22, 2017
d01c9af
Swapp operand order for bitwise shifting
axic Sep 22, 2017
74d9a17
Clarify wording about arg1/arg2
axic Sep 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use floor and not udiv/sdiv
  • Loading branch information
@axic
axic committed Jul 3, 2017
commit e5ca9196720c2a52134ce922ba80638e40ad5614
4 changes: 2 additions & 2 deletions EIPS/eip-145.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Notes:
The `SHR` instruction (logical shift right) pops 2 values from the stack, `arg1` and `arg2`, and pushes on the stack the first popped value `arg1` shifted to the right by the number of bits in the second popped value `arg2` with zero fill. The result is equal to

```
arg1 udiv 2^arg2
floor(arg1 / 2^arg2)
```

Notes:
Expand All @@ -54,7 +54,7 @@ Notes:
The `SAR` instruction (arithmetic shift right) pops 2 values from the stack, `arg1` and `arg2`, and pushes on the stack the first popped value `arg1` shifted to the right by the number of bits in the second popped value `arg2` with sign extension. The result is equal to

```
arg1 sdiv 2^arg2
floor(arg1 / 2^arg2)
```

Notes:
Expand Down