Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed subscription API, and simplified #1809

Merged
merged 1 commit into from
Mar 3, 2019

Commits on Mar 3, 2019

  1. Fixed subscription API, and simplified

    After carefully reading this again, i noticed that there was an issue with the subscription.
    One should put the subscription type in, so that the notification can pre-filter based on the subscription type (`eth_subscription`, `ssh_subscription`). Athen the returned object is within this subscription type, and mapping of sub IDs can be done properly.
    
    Also the standard should not talk about JSON RPC, as this provider is meant to abstract that away. Under the hood it probably will have to create a son roc object, depending on how it communicates with the node.
    
    I'm personally not sure if the `accountsChanged` and `networkChanged` events should be in this standard.
    
    I certainly think the `eth_requestAccounts` should be in another standards proposal and not in the initial one here.
    frozeman authored Mar 3, 2019
    Configuration menu
    Copy the full SHA
    7680560 View commit details
    Browse the repository at this point in the history