-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce AnchorStateRegistry #9835
Conversation
Still needs tests |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9835 +/- ##
============================================
- Coverage 28.53% 16.17% -12.37%
============================================
Files 164 123 -41
Lines 7211 5297 -1914
Branches 1321 1173 -148
============================================
- Hits 2058 857 -1201
+ Misses 5047 4365 -682
+ Partials 106 75 -31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far. Couple suggestions + a bug.
packages/contracts-bedrock/src/dispute/interfaces/IAnchorStateRegistry.sol
Outdated
Show resolved
Hide resolved
bdceff8
to
f84e452
Compare
WalkthroughThe update involves transitioning from genesis-related terminology to start-focused terms, broadening their relevance beyond the initial block. It introduces the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
packages/contracts-bedrock/test/kontrol/proofs/utils/DeploymentSummary.sol
Outdated
Show resolved
Hide resolved
f84e452
to
c8ce055
Compare
I could use some assistance re-generating the Kontrol artifacts. I can never seem to get them to generate properly, who knows why. |
c8ce055
to
cda2b37
Compare
cda2b37
to
b523040
Compare
Introduces the AnchorStateRegistry used to hold anchor states for different game types. Anchor states are updated automatically when a game resolves.
b523040
to
ce7f4ca
Compare
Description
Introduces the AnchorStateRegistry used to hold anchor states for different game types. Anchor states are updated automatically when a game resolves.