Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-wheel: Add set-fcu-by-hash and copy-payload #9574

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

trianglesphere
Copy link
Contributor

Description

Add set-fcu-by-hash and copy-payload commands to op-wheel

Additional context

Note: copy and copy-payload do not work if there is a deposit in the block. I'm unsure why it is not serializing properly.

@trianglesphere trianglesphere requested a review from a team as a code owner February 16, 2024 02:44
Copy link
Contributor

coderabbitai bot commented Feb 16, 2024

Walkthrough

Walkthrough

The recent updates bring two new commands, copy-payload and set-forkchoice-by-hash, aimed at enhancing blockchain operations. copy-payload facilitates block copying between sources and the engine using a new payload, while set-forkchoice-by-hash enables updating fork choice with block hashes. These additions improve blockchain management by simplifying payload copying and enhancing fork choice mechanisms.

Changes

Files Changes
op-wheel/commands.go Added copy-payload and set-forkchoice-by-hash commands. Updated EngineCmd accordingly.
op-wheel/engine/engine.go Introduced CopyPayload function for copying execution payload based on block number. Added SetForkchoiceByHash for updating fork choice using hashes.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@trianglesphere trianglesphere changed the title Jg/op wheel hash fcu op-wheel: Add set-fcu-by-hash and copy-payload Feb 16, 2024
op-wheel/commands.go Outdated Show resolved Hide resolved
op-wheel/engine/engine.go Show resolved Hide resolved
op-wheel/commands.go Show resolved Hide resolved
op-wheel/engine/engine.go Show resolved Hide resolved
op-wheel/commands.go Outdated Show resolved Hide resolved
@protolambda protolambda added this pull request to the merge queue Feb 22, 2024
Merged via the queue into develop with commit 9a0212a Feb 22, 2024
68 checks passed
@protolambda protolambda deleted the jg/op-wheel-hash-fcu branch February 22, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants