Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predeploy -> Preinstall #8964

Merged
merged 5 commits into from
Jan 13, 2024
Merged

Predeploy -> Preinstall #8964

merged 5 commits into from
Jan 13, 2024

Conversation

spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Jan 11, 2024

We've decided to call the newly added predeploys, preinstalls. This PR does some renaming and inits a Preinstall spec file

Copy link
Contributor

coderabbitai bot commented Jan 11, 2024

Warning

Rate Limit Exceeded

@spacesailor24 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 36 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between b3978bf and fe76631.

Walkthrough

The changes indicate a terminology shift from "predeploys" to "preinstalls" within the documentation and specs of a software project, likely related to smart contracts on the Optimism network. The updates involve removing certain public entities, updating contract information, and adding a new section to the glossary to define "Preinstalled Contract."

Changes

File Path Change Summary
op-bindings/bindgen/README.md Replaced "predeploys" with "preinstalls"; minor description updates.
specs/glossary.md Added "Preinstalled Contract" section with definition.
specs/predeploys.md Removed several public entities; updated EAS info; removed LegacyMessagePasser section.
specs/preinstalls.md New overview of preinstalled contracts on Optimism network with detailed information.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@spacesailor24
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@spacesailor24 spacesailor24 requested review from mds1 and removed request for smartcontracts January 11, 2024 23:15
specs/preinstalls.md Outdated Show resolved Hide resolved
specs/preinstalls.md Outdated Show resolved Hide resolved
specs/preinstalls.md Outdated Show resolved Hide resolved
@spacesailor24 spacesailor24 force-pushed the wyatt/preinstalls/renaming branch 2 times, most recently from 8c2886e to 023842e Compare January 11, 2024 23:22
specs/preinstalls.md Outdated Show resolved Hide resolved
specs/preinstalls.md Outdated Show resolved Hide resolved
specs/preinstalls.md Outdated Show resolved Hide resolved
specs/preinstalls.md Outdated Show resolved Hide resolved
specs/preinstalls.md Outdated Show resolved Hide resolved
@spacesailor24 spacesailor24 force-pushed the wyatt/preinstalls/renaming branch 2 times, most recently from f87b390 to 4ff4f8e Compare January 12, 2024 00:33
@spacesailor24 spacesailor24 requested review from tynes and mds1 January 12, 2024 00:34
specs/predeploys.md Show resolved Hide resolved
specs/predeploys.md Show resolved Hide resolved
@spacesailor24 spacesailor24 force-pushed the wyatt/preinstalls/renaming branch from 4ff4f8e to 6e35245 Compare January 12, 2024 01:36
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions

specs/glossary.md Outdated Show resolved Hide resolved
specs/glossary.md Outdated Show resolved Hide resolved
spacesailor24 and others added 2 commits January 12, 2024 08:58
Co-authored-by: refcell.eth <abigger87@gmail.com>
Co-authored-by: refcell.eth <abigger87@gmail.com>
specs/glossary.md Outdated Show resolved Hide resolved
@spacesailor24 spacesailor24 requested a review from refcell January 12, 2024 19:04
@spacesailor24 spacesailor24 requested a review from tynes January 12, 2024 19:04
@spacesailor24 spacesailor24 added this pull request to the merge queue Jan 12, 2024
@spacesailor24 spacesailor24 removed this pull request from the merge queue due to a manual request Jan 12, 2024
@spacesailor24 spacesailor24 added this pull request to the merge queue Jan 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 12, 2024
@trianglesphere trianglesphere added this pull request to the merge queue Jan 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 12, 2024
@spacesailor24 spacesailor24 added this pull request to the merge queue Jan 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 12, 2024
@spacesailor24 spacesailor24 added this pull request to the merge queue Jan 12, 2024
Merged via the queue into develop with commit db25f4b Jan 13, 2024
66 checks passed
@spacesailor24 spacesailor24 deleted the wyatt/preinstalls/renaming branch January 13, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants