Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update op-geth to latest version with fixed BaseFee naming #8962

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

roberto-bayardo
Copy link
Collaborator

@roberto-bayardo roberto-bayardo commented Jan 11, 2024

Description

Updates geth to v1.101305.2-rc.2 to continue with Ecotone work.

Copy link
Contributor

coderabbitai bot commented Jan 11, 2024

Walkthrough

Walkthrough

The recent changes are focused on standardizing the naming convention of certain variables within the codebase. The modifications are specifically related to the terms "basefee" and "BaseFee," ensuring that they are consistently capitalized across various variable names. This includes changes to slot names and offsets, aligning them with a uniform naming pattern that emphasizes readability and code style consistency.

Changes

File Summary
op-bindings/predeploys/addresses_test.go Renamed variables for consistency: "L1Basefee" to "L1BaseFee", "Basefee" to "BaseFee", "L1BlobBasefeeSlot" to "L1BlobBaseFeeSlot", and "BlobBasefeeScalarSlotOffset" to "BlobBaseFeeScalarSlotOffset".

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@roberto-bayardo roberto-bayardo requested a review from tynes January 11, 2024 22:32
@roberto-bayardo roberto-bayardo changed the title update geth to latest version with fixed BaseFee naming update op-geth to latest version with fixed BaseFee naming Jan 11, 2024
@ajsutton ajsutton added this pull request to the merge queue Jan 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7bd8fa) 34.66% compared to head (4dee578) 34.70%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8962      +/-   ##
===========================================
+ Coverage    34.66%   34.70%   +0.04%     
===========================================
  Files          165      165              
  Lines         7123     7123              
  Branches      1208     1208              
===========================================
+ Hits          2469     2472       +3     
+ Misses        4504     4499       -5     
- Partials       150      152       +2     
Flag Coverage Δ
cannon-go-tests 63.48% <ø> (ø)
chain-mon-tests 27.14% <ø> (ø)
common-ts-tests 26.74% <ø> (ø)
contracts-bedrock-tests 20.40% <ø> (+0.14%) ⬆️
contracts-ts-tests 12.25% <ø> (ø)
core-utils-tests 44.03% <ø> (ø)
sdk-next-tests 42.08% <ø> (ø)
sdk-tests 42.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@protolambda protolambda added this pull request to the merge queue Jan 12, 2024
Merged via the queue into ethereum-optimism:develop with commit 25aefb7 Jan 12, 2024
64 checks passed
@roberto-bayardo roberto-bayardo deleted the update-geth branch March 21, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants