-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat(op-program): Minimal Reproducible Absolute Prestate #8957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe project has undergone significant updates to enhance reproducibility and verification processes. Changes include the introduction of Docker with buildkit for generating reproducible builds, a multi-stage Dockerfile for the Go application, adjustments to the CI workflow to include prestate validation, and Makefile targets for building and verifying the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
#8885 should be updated to use this method for CI |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8957 +/- ##
============================================
+ Coverage 34.70% 63.48% +28.78%
============================================
Files 165 16 -149
Lines 7123 1427 -5696
Branches 1208 0 -1208
============================================
- Hits 2472 906 -1566
+ Misses 4499 475 -4024
+ Partials 152 46 -106
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works well. I'd just simplify the doc changes to minimise the risk of it getting out of sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.

Description
Introduces a minimal reproducible absolute prestate build using a custom dockerfile with explicit versioned dependencies.
1.21.33.18This dockerfile can be run using the added top-level makefile target
reproducible-prestate.The cannon docs in
cannon/README.mdare updated to use this target to generate the absolute prestate andop-programbinary passed into cannon.This PR does NOT add the reproducible absolute prestate build to ci, which still uses the
make cannon-prestatemakefile target.Metadata
Fixes https://github.com/ethereum-optimism/client-pod/issues/442