fix baseFee naming consistency in L2 Contracts

[roberto-bayardo]

Description

Consistently use BaseFee instead of Basefee in l2 contracts.

[coderabbitai]

Walkthrough

Walkthrough

The recent updates across several contracts and tests in the Bedrock package focus on standardizing the naming convention for variables related to gas pricing. Specifically, the term 'basefee' has been consistently changed to 'baseFee', and similar adjustments have been made for variables prefixed with 'blobBasefee' and suffixed with 'Scalar'. These changes are reflected across function names, parameters, and internal variables to improve clarity and adherence to naming standards.

Changes

File(s)	Summary of Changes
.../GasPriceOracle.sol, .../L1Block.sol, .../Encoding.sol	Renamed basefee to baseFee and blobBasefee to blobBaseFee. Updated basefeeScalar to baseFeeScalar and blobBasefeeScalar to blobBaseFeeScalar. Refactored internal function variables to align with the new naming convention.
.../GasPriceOracle.t.sol, .../L1Block.t.sol	Updated tests to reflect the renaming of basefee to baseFee, blobBasefee to blobBaseFee, and their respective 'Scalar' variants. Modified assertions to align with the new parameter names.
.../addresses_test.go	Renamed variables to adhere to a consistent naming convention and updated references accordingly.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[codecov]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e109fed) 34.70% compared to head (50d08eb) 34.70%.
Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #8954   +/-   ##
========================================
  Coverage    34.70%   34.70%           
========================================
  Files          165      165           
  Lines         7123     7123           
  Branches      1208     1208           
========================================
  Hits          2472     2472           
  Misses        4499     4499           
  Partials       152      152           

Flag	Coverage Δ
cannon-go-tests	63.48% <ø> (ø)
chain-mon-tests	27.14% <ø> (ø)
common-ts-tests	26.74% <ø> (ø)
contracts-bedrock-tests	20.40% <0.00%> (ø)
contracts-ts-tests	12.25% <ø> (ø)
core-utils-tests	44.03% <ø> (ø)
sdk-next-tests	42.08% <ø> (ø)
sdk-tests	42.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
packages/contracts-bedrock/src/L2/L1Block.sol	80.00% <ø> (ø)
...kages/contracts-bedrock/src/libraries/Encoding.sol	34.48% <ø> (ø)
...ckages/contracts-bedrock/src/L2/GasPriceOracle.sol	0.00% <0.00%> (ø)