contracts-bedrock: cleanup predeploys solidity test #8933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughWalkthroughThe recent update involves simplifying the logic for checking predeploy proxy configurations in a Go command, removing parallel checks for a more straightforward approach. In Solidity testing, new internal functions have been introduced to handle the computation of predeploy addresses, verification of predeploy status, and proxy determination. Additionally, a test function has been enhanced to verify predeploy settings and admin configurations. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8933 +/- ##
===========================================
- Coverage 34.70% 25.80% -8.91%
===========================================
Files 165 117 -48
Lines 7123 4841 -2282
Branches 1208 1057 -151
===========================================
- Hits 2472 1249 -1223
+ Misses 4499 3486 -1013
+ Partials 152 106 -46
Flags with carried forward coverage won't be shown. Click here to find out more. |
tynes
force-pushed
the
ctb/cleanup-l2-check
branch
from
cfd3792 to
9ef59df
Compare
refcell
reviewed
Jan 10, 2024
refcell
approved these changes
Jan 10, 2024
tynes
added a commit
that referenced
this pull request
Jan 11, 2024
This is a prereq of #8942. This will help to remove the concept of `check-l2` to help reduce the amount of diff a developer needs to do when making changes to the solidity code. Ideally, a solidity dev needs to touch 0 code in any other language (besides bash ffi lolz). After this PR as well as: - #8933 - #8911 the functionality of `check-l2` is now completely in solidity. Note that we are now calling the non system contracts "preinstalls" instead of "predeploys" to denote that they do not live in the predeploy namespace and are not critical to the functionality of the system. They are set at deterministic addresses.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Contributors to the smart contracts have way too many steps to get their PR over the line. This migrates some of the `check-l2` script to solidity. I believe that we can fully delete `check-l2` but want to follow up in an additional PR to ensure that we have the same functionality. Completely deleting `check-l2` was unblocked by #8911. The functionality that is added to the solidity here was removed from the `check-l2` script.
tynes
force-pushed
the
ctb/cleanup-l2-check
branch
from
9ef59df to
06cc8a6
Compare
tynes
added a commit
that referenced
this pull request
Jan 11, 2024
This is a prereq of #8942. This will help to remove the concept of `check-l2` to help reduce the amount of diff a developer needs to do when making changes to the solidity code. Ideally, a solidity dev needs to touch 0 code in any other language (besides bash ffi lolz). After this PR as well as: - #8933 - #8911 the functionality of `check-l2` is now completely in solidity. Note that we are now calling the non system contracts "preinstalls" instead of "predeploys" to denote that they do not live in the predeploy namespace and are not critical to the functionality of the system. They are set at deterministic addresses.
0xfuturistic
pushed a commit
that referenced
this pull request
Jan 11, 2024
* contracts-bedrock: cleanup predeploys solidity test Contributors to the smart contracts have way too many steps to get their PR over the line. This migrates some of the `check-l2` script to solidity. I believe that we can fully delete `check-l2` but want to follow up in an additional PR to ensure that we have the same functionality. Completely deleting `check-l2` was unblocked by #8911. The functionality that is added to the solidity here was removed from the `check-l2` script. * op-chain-ops: remove dead code * op-chain-ops: fix build issue
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
* contracts-bedrock: add tests for preinstalls This is a prereq of #8942. This will help to remove the concept of `check-l2` to help reduce the amount of diff a developer needs to do when making changes to the solidity code. Ideally, a solidity dev needs to touch 0 code in any other language (besides bash ffi lolz). After this PR as well as: - #8933 - #8911 the functionality of `check-l2` is now completely in solidity. Note that we are now calling the non system contracts "preinstalls" instead of "predeploys" to denote that they do not live in the predeploy namespace and are not critical to the functionality of the system. They are set at deterministic addresses. * contracts-bedrock: lint * contracts-bedrock: lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributors to the smart contracts have way too many steps
to get their PR over the line. This migrates some of the
check-l2script to solidity. I believe that we can fully delete
check-l2but want to follow up in an additional PR to ensure that we have the
same functionality. Completely deleting
check-l2was unblocked by#8911.
The functionality that is added to the solidity here was removed from
the
check-l2script.