op-node: Remove Unsafe Sync Target & Direct Engine Manipulation #8856

trianglesphere · 2024-01-05T01:59:55Z

Description

This PR primarily moves the last of the direct execution engine manipulation from the EngineQueue to the EngineController. It also removes the unsafe sync target because maintaining the unsafe sync target was difficult and will be replaced by a different EL sync method.

Tests

Again no tests because this is tidying.

op-node/rollup/derive/engine_queue.go

semgrep-app · 2024-01-05T23:25:16Z

Semgrep found 1 sol-style-notice-over-dev-natspec finding:

packages/contracts-bedrock/src/dispute/interfaces/IFaultDisputeGame.sol: L12

Prefer @notice over @dev in natspec comments

_{Ignore this finding from sol-style-notice-over-dev-natspec.}

codecov · 2024-01-05T23:47:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (320fe93) 34.70% compared to head (164f472) 20.40%.
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #8856       +/-   ##
============================================
- Coverage    34.70%   20.40%   -14.30%     
============================================
  Files          165       86       -79     
  Lines         7123     2058     -5065     
  Branches      1208      473      -735     
============================================
- Hits          2472      420     -2052     
+ Misses        4499     1607     -2892     
+ Partials       152       31      -121

Flag	Coverage Δ
cannon-go-tests	`?`
chain-mon-tests	`?`
common-ts-tests	`?`
contracts-bedrock-tests	`20.40% <ø> (ø)`
contracts-ts-tests	`?`
core-utils-tests	`?`
sdk-next-tests	`?`
sdk-tests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 79 files with indirect coverage changes

coderabbitai · 2024-01-09T00:26:09Z

Warning

Rate Limit Exceeded

@trianglesphere has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 29 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 320fe93 and 164f472.

Walkthrough

The overarching modification involves the removal of the EngineSyncTarget method and associated logic across various components of the system. This suggests a refactoring or redesign of how engine synchronization targets are handled, with a shift towards new methods and fields that likely streamline the synchronization process. The changes impact tests, synchronization status reporting, and engine control mechanisms, indicating a significant update to the synchronization strategy within the system's architecture.

Changes

Files	Change Summary
`op-e2e/actions/l2_verifier.go` `op-node/node/server_test.go` `op-node/rollup/derive/pipeline.go` `op-node/rollup/driver/driver.go` `op-node/rollup/driver/state.go` `op-service/eth/sync_status.go` `op-service/testutils/random.go`	Removal of `EngineSyncTarget` method and related logic, impacting synchronization status and engine control.
`op-e2e/actions/sync_test.go` `op-node/rollup/derive/engine_queue_test.go`	Modifications to test logic, replacing hash comparisons involving `EngineSyncTarget` with `L2Unsafe` and updating fork choice update handling.
`op-node/rollup/derive/engine_controller.go` `op-node/rollup/derive/engine_queue.go`	Introduction of new fields (`syncMode`, `needFCUCall`), removal of old fields (`syncTarget`, `needForkchoiceUpdate`), and addition of new methods (`checkNewPayloadStatus`, `checkForkchoiceUpdatedStatus`, `resetBuildingState`), with updates to existing methods to accommodate these changes.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit-tests for this file.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit tests for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository from git and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit tests.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

op-node/rollup/derive/engine_queue_test.go

op-e2e/actions/sync_test.go

op-node/rollup/derive/engine_queue.go

op-service/eth/sync_status.go

This fully moves all execution engine manipulation into the Engine Controller from the Engine Queue. It does not remove the proxy methods however.

pcw109550 · 2024-01-10T05:02:18Z

op-node/rollup/derive/engine_controller.go

@@ -165,7 +164,6 @@ func (e *EngineController) ConfirmPayload(ctx context.Context) (out *eth.Executi
 	}

 	e.unsafeHead = ref
-	e.syncTarget = ref

 	e.metrics.RecordL2Ref("l2_unsafe", ref)
 	e.metrics.RecordL2Ref("l2_engineSyncTarget", ref)


Need to remove this as well.

…reum-optimism#8856) This fully moves all execution engine manipulation into the Engine Controller from the Engine Queue. It does not remove the proxy methods however.

This fully moves all execution engine manipulation into the Engine Controller from the Engine Queue. It does not remove the proxy methods however.

semgrep-app bot reviewed Jan 5, 2024

View reviewed changes

op-node/rollup/derive/engine_queue.go Outdated Show resolved Hide resolved

semgrep-app bot reviewed Jan 5, 2024

View reviewed changes

op-node/rollup/derive/engine_queue.go Outdated Show resolved Hide resolved

trianglesphere force-pushed the jg/engine_controller_v3 branch from 7086c1d to 1995e9f Compare January 5, 2024 23:24

trianglesphere force-pushed the jg/engine_controller_v2 branch from e6b1ee6 to 47f6f63 Compare January 5, 2024 23:43

trianglesphere force-pushed the jg/engine_controller_v3 branch from 1995e9f to 1ec6a98 Compare January 5, 2024 23:47

trianglesphere changed the base branch from jg/engine_controller_v2 to develop January 5, 2024 23:47

trianglesphere changed the base branch from develop to jg/engine_controller_v2 January 5, 2024 23:47

trianglesphere changed the base branch from jg/engine_controller_v2 to develop January 5, 2024 23:48

trianglesphere changed the base branch from develop to jg/engine_controller_v2 January 8, 2024 21:16

trianglesphere changed the title ~~Jg/engine controller v3~~ op-node: Remove Unsafe Sync Target & Direct Engine Manipulation Jan 8, 2024

Base automatically changed from jg/engine_controller_v2 to develop January 9, 2024 00:07

trianglesphere force-pushed the jg/engine_controller_v3 branch from 1ec6a98 to 66f70b1 Compare January 9, 2024 00:24

trianglesphere marked this pull request as ready for review January 9, 2024 00:26

trianglesphere requested review from a team, protolambda and ajsutton as code owners January 9, 2024 00:26

coderabbitai bot reviewed Jan 9, 2024

View reviewed changes

ajsutton reviewed Jan 9, 2024

View reviewed changes

axelKingsley requested review from axelKingsley and removed request for axelKingsley January 9, 2024 17:20

trianglesphere force-pushed the jg/engine_controller_v3 branch 2 times, most recently from eeae377 to 714a127 Compare January 9, 2024 18:34

op-node: Remove Unsafe Sync Target & Direct Engine Manipulation

164f472

This fully moves all execution engine manipulation into the Engine Controller from the Engine Queue. It does not remove the proxy methods however.

trianglesphere force-pushed the jg/engine_controller_v3 branch from 714a127 to 164f472 Compare January 9, 2024 18:37

trianglesphere requested a review from ajsutton January 9, 2024 18:41

ajsutton approved these changes Jan 9, 2024

View reviewed changes

trianglesphere added this pull request to the merge queue Jan 10, 2024

Merged via the queue into develop with commit 509772a Jan 10, 2024
68 checks passed

trianglesphere deleted the jg/engine_controller_v3 branch January 10, 2024 01:47

pcw109550 reviewed Jan 10, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

op-node: Remove Unsafe Sync Target & Direct Engine Manipulation #8856

op-node: Remove Unsafe Sync Target & Direct Engine Manipulation #8856

trianglesphere commented Jan 5, 2024 •

edited

Loading

semgrep-app bot commented Jan 5, 2024

codecov bot commented Jan 5, 2024 •

edited

Loading

coderabbitai bot commented Jan 9, 2024 •

edited

Loading

Rate Limit Exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

CodeRabbit Discord Community

pcw109550 Jan 10, 2024

op-node: Remove Unsafe Sync Target & Direct Engine Manipulation #8856

op-node: Remove Unsafe Sync Target & Direct Engine Manipulation #8856

Conversation

trianglesphere commented Jan 5, 2024 • edited Loading

semgrep-app bot commented Jan 5, 2024

codecov bot commented Jan 5, 2024 • edited Loading

Codecov Report

coderabbitai bot commented Jan 9, 2024 • edited Loading

Rate Limit Exceeded

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

CodeRabbit Discord Community

pcw109550 Jan 10, 2024

Choose a reason for hiding this comment

trianglesphere commented Jan 5, 2024 •

edited

Loading

codecov bot commented Jan 5, 2024 •

edited

Loading

coderabbitai bot commented Jan 9, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)