Skip to content

Conversation

@roninjin10
Copy link
Contributor

  • Git is unused
  • Including it makes some builds like render.com fail

@roninjin10 roninjin10 requested a review from a team as a code owner September 1, 2023 15:49
@roninjin10
Copy link
Contributor Author

roninjin10 commented Sep 1, 2023

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot added the S-on-merge-train Status: This PR is in the merge queue label Sep 1, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #7087 (ce0f111) into develop (0d4936e) will increase coverage by 3.03%.
Report is 3 commits behind head on develop.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #7087      +/-   ##
===========================================
+ Coverage    45.59%   48.62%   +3.03%     
===========================================
  Files          389      321      -68     
  Lines        30546    24335    -6211     
  Branches      1692        0    -1692     
===========================================
- Hits         13926    11832    -2094     
+ Misses       15130    11441    -3689     
+ Partials      1490     1062     -428     
Flag Coverage Δ
bedrock-go-tests 48.62% <ø> (-0.01%) ⬇️
cannon-go-tests ?
chain-mon-tests ?
common-ts-tests ?
contracts-bedrock-tests ?
contracts-ts-tests ?
core-utils-tests ?
sdk-next-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@OptimismBot OptimismBot merged commit cf040a8 into develop Sep 1, 2023
@OptimismBot OptimismBot deleted the willc/remove-git-dep branch September 1, 2023 17:23
@mergify mergify bot removed the S-on-merge-train Status: This PR is in the merge queue label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-indexer Area: indexer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants