Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-chain-ops: delete migration code #5996

Merged
merged 4 commits into from
Jun 12, 2023
Merged

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jun 12, 2023

Description

Delete the migration code to reduce the amount of diff required when making changes to the codebase. This code can be found in the legacy repo: https://github.com/ethereum-optimism/optimism-legacy

Deleted a lot of code that will never be used again

@tynes tynes requested a review from a team as a code owner June 12, 2023 17:58
@tynes tynes requested a review from Inphi June 12, 2023 17:58
@changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2023

⚠️ No Changeset found

Latest commit: 69b0f46

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 12, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 69b0f46
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/648774e3c39d4100089b69e0

Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a codeowner here, but LGTM

@tynes tynes requested a review from a team as a code owner June 12, 2023 18:26
@mergify mergify bot added the A-indexer Area: indexer label Jun 12, 2023
@mergify mergify bot requested a review from roninjin10 June 12, 2023 18:26
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

Hey @tynes, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue.
More details can be found on the Queue: Embarked in merge train check-run.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #5996 (5fecaa9) into develop (7cbc553) will increase coverage by 8.63%.
The diff coverage is n/a.

❗ Current head 5fecaa9 differs from pull request most recent head b5bc9a9. Consider uploading reports for the commit b5bc9a9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5996      +/-   ##
===========================================
+ Coverage    37.23%   45.87%   +8.63%     
===========================================
  Files          309      411     +102     
  Lines        24119    25275    +1156     
  Branches         0      714     +714     
===========================================
+ Hits          8981    11595    +2614     
+ Misses       14352    12699    -1653     
- Partials       786      981     +195     
Flag Coverage Δ
bedrock-go-tests 45.96% <ø> (+8.72%) ⬆️
common-ts-tests 26.82% <ø> (?)
contracts-bedrock-tests 54.37% <ø> (?)
contracts-tests 42.14% <ø> (?)
core-utils-tests 60.41% <ø> (?)
fault-detector-tests 29.51% <ø> (?)
sdk-tests 39.75% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-chain-ops/crossdomain/migrate.go 59.21% <ø> (+59.21%) ⬆️
op-chain-ops/genesis/genesis.go 85.71% <ø> (+4.28%) ⬆️
op-chain-ops/genesis/setters.go 62.16% <ø> (+62.16%) ⬆️

... and 140 files with indirect coverage changes

Delete the migration code to reduce the amount of diff required when
making changes to the codebase. This code can be found in the legacy repo:
https://github.com/ethereum-optimism/optimism-legacy

Deleted a lot of code that will never be used again
@semgrep-app
Copy link
Contributor

semgrep-app bot commented Jun 12, 2023

Semgrep found 2 incomplete-sanitization findings:

  • packages/migration-data/bin/cli.ts: L31, L29

line.split('|')[2].replace method will only replace the first occurrence when used with a string argument ('\r'). If this method is used for escaping of dangerous data then there is a possibility for a bypass. Try to use sanitization library instead or use a Regex with a global flag.

Ignore this finding from incomplete-sanitization.

@tynes tynes force-pushed the cleanup/delete-extra-migration-code branch from efa026b to 69b0f46 Compare June 12, 2023 19:41
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

This PR has been added to the merge queue, and will be merged soon.

@tynes tynes merged commit 71aadcf into develop Jun 12, 2023
@tynes tynes deleted the cleanup/delete-extra-migration-code branch June 12, 2023 20:01
@mergify mergify bot removed the on-merge-train label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-indexer Area: indexer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants