Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: delete migration-data #5965

Merged
merged 4 commits into from
Jun 12, 2023
Merged

cleanup: delete migration-data #5965

merged 4 commits into from
Jun 12, 2023

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jun 9, 2023

Description

Deletes the migration-data package from the packages directory. This package is no longer useful and will exist in a previous commit/fork of the repo. It will be very painful to maintain the ability to run the migration indefinitely into the future, it should be safe to assume that users that want to perform the migration can check out the legacy commit and run it from that point.

@tynes tynes requested review from a team as code owners June 9, 2023 18:37
@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2023

⚠️ No Changeset found

Latest commit: 5246edd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 5246edd
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/648767d31cada10008ed0f98

@refcell
Copy link
Contributor

refcell commented Jun 9, 2023

Let the record show the diff

+0
-398,352

@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2023

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 9, 2023
@tynes tynes force-pushed the cleanup/delete-migration-data branch from 32557ad to 9c2973c Compare June 9, 2023 20:20
@mergify mergify bot removed the conflict label Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #5965 (9c2973c) into develop (fa36d8b) will increase coverage by 13.24%.
The diff coverage is n/a.

❗ Current head 9c2973c differs from pull request most recent head 5246edd. Consider uploading reports for the commit 5246edd to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5965       +/-   ##
============================================
+ Coverage    27.97%   41.21%   +13.24%     
============================================
  Files          415      435       +20     
  Lines        27952    29624     +1672     
  Branches       714      714               
============================================
+ Hits          7819    12210     +4391     
+ Misses       19569    16388     -3181     
- Partials       564     1026      +462     
Flag Coverage Δ
bedrock-go-tests 40.66% <ø> (+15.19%) ⬆️
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 54.22% <ø> (-0.16%) ⬇️
contracts-tests 42.19% <ø> (+0.04%) ⬆️
core-utils-tests 60.41% <ø> (ø)
fault-detector-tests 29.51% <ø> (ø)
sdk-tests 39.84% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 114 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 12, 2023
Deletes the `migration-data` package from the `packages`
directory. This package is no longer useful and will exist
in a previous commit/fork of the repo. It will be very painful
to maintain the ability to run the migration indefinitely
into the future, it should be safe to assume that users
that want to perform the migration can check out the legacy
commit and run it from that point.
@tynes tynes force-pushed the cleanup/delete-migration-data branch from 9c2973c to 5246edd Compare June 12, 2023 18:45
@mergify mergify bot removed the conflict label Jun 12, 2023
@tynes tynes merged commit eefb3f8 into develop Jun 12, 2023
@tynes tynes deleted the cleanup/delete-migration-data branch June 12, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants