Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: delete legacy docker builds #5963

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

tynes
Copy link
Contributor

@tynes tynes commented Jun 9, 2023

Description

Delete some legacy config for building docker images that are no longer used.

@tynes tynes requested a review from a team as a code owner June 9, 2023 18:10
@tynes tynes requested a review from mslipper June 9, 2023 18:10
@changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2023

⚠️ No Changeset found

Latest commit: 2cdac1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 9, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 2cdac1b
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6487697f2412e40008ac7ff3

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #5963 (0c07e23) into develop (fa36d8b) will increase coverage by 13.23%.
The diff coverage is n/a.

❗ Current head 0c07e23 differs from pull request most recent head 2cdac1b. Consider uploading reports for the commit 2cdac1b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5963       +/-   ##
============================================
+ Coverage    27.97%   41.20%   +13.23%     
============================================
  Files          415      435       +20     
  Lines        27952    29624     +1672     
  Branches       714      714               
============================================
+ Hits          7819    12208     +4389     
+ Misses       19569    16387     -3182     
- Partials       564     1029      +465     
Flag Coverage Δ
bedrock-go-tests 40.65% <ø> (+15.18%) ⬆️
common-ts-tests 26.82% <ø> (ø)
contracts-bedrock-tests 54.22% <ø> (-0.16%) ⬇️
contracts-tests 42.19% <ø> (+0.04%) ⬆️
core-utils-tests 60.41% <ø> (ø)
fault-detector-tests 29.51% <ø> (ø)
sdk-tests 39.84% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 114 files with indirect coverage changes

@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2023

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 9, 2023
@tynes tynes force-pushed the cleanup/delete-legacy-docker-builds branch from a9d33b9 to 5454122 Compare June 9, 2023 19:17
@mergify mergify bot removed the conflict label Jun 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2023

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 9, 2023
@tynes tynes force-pushed the cleanup/delete-legacy-docker-builds branch from 5454122 to 0c07e23 Compare June 9, 2023 20:21
@mergify mergify bot removed the conflict label Jun 9, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

Hey @tynes! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jun 12, 2023
Delete some legacy config for building docker images
that are no longer used.
@tynes tynes force-pushed the cleanup/delete-legacy-docker-builds branch from 0c07e23 to 2cdac1b Compare June 12, 2023 18:52
@mergify mergify bot removed the conflict label Jun 12, 2023
@tynes tynes merged commit 9576bed into develop Jun 12, 2023
@tynes tynes deleted the cleanup/delete-legacy-docker-builds branch June 12, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant